Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1414)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2120233003: [OBSOLETE] Remove WebURLResponse::initialize() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix formatting issues and one last compile error Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 7bcfe3548e3d7bed75ebe5789e6e980f0bfa077d..575590f71e6bef4598f96958f58044e8f050d740 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -206,7 +206,6 @@ protected:
void registerMockedHttpURLLoadWithCSP(const std::string& fileName, const std::string& csp, bool reportOnly = false)
{
WebURLResponse response;
- response.initialize();
response.setMIMEType("text/html");
response.addHTTPHeaderField(reportOnly ? WebString("Content-Security-Policy-Report-Only") : WebString("Content-Security-Policy"), WebString::fromUTF8(csp));
std::string fullString = m_baseURL + fileName;
@@ -5072,7 +5071,6 @@ TEST_P(ParameterizedWebFrameTest, ReplaceNavigationAfterHistoryNavigation)
error.domain = "WebFrameTest";
std::string errorURL = "http://0.0.0.0";
WebURLResponse response;
- response.initialize();
response.setURL(URLTestHelpers::toKURL(errorURL));
response.setMIMEType("text/html");
response.setHTTPStatusCode(500);
@@ -5718,14 +5716,12 @@ TEST_P(ParameterizedWebFrameTest, FirstPartyForCookiesForRedirect)
char redirect[] = "http://internal.test/first_party.html";
WebURL redirectURL(toKURL(redirect));
WebURLResponse redirectResponse;
- redirectResponse.initialize();
redirectResponse.setMIMEType("text/html");
redirectResponse.setHTTPStatusCode(302);
redirectResponse.setHTTPHeaderField("Location", redirect);
Platform::current()->getURLLoaderMockFactory()->registerURL(testURL, redirectResponse, filePath);
WebURLResponse finalResponse;
- finalResponse.initialize();
finalResponse.setMIMEType("text/html");
Platform::current()->getURLLoaderMockFactory()->registerURL(redirectURL, finalResponse, filePath);

Powered by Google App Engine
This is Rietveld 408576698