[OBSOLETE] Remove WebURLResponse::initialize()

third_party/WebKit/Source/platform/exported/WrappedResourceResponse.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #ifndef WrappedResourceResponse_h
 #define WrappedResourceResponse_h
 
 #include "platform/exported/WebURLResponsePrivate.h"
 #include "public/platform/WebURLResponse.h"
 #include "wtf/Allocator.h"
 
 namespace blink {
 
 class WrappedResourceResponse : public WebURLResponse {

[kinuko, 2016/07/05 14:59:44]

Hmm ok, WebURLResponsePrivate is non-copyable so this one's non-copyable too...
could we explicitly mark this WTF_MAKE_NONCOPYABLE too to avoid confusion?

[kinuko, 2016/07/05 14:59:44]

How this one's copy assignment works?

 public:
-    ~WrappedResourceResponse()
-    {
-        reset(); // Need to drop reference to m_handle
-    }
+    ~WrappedResourceResponse() {}
 
     WrappedResourceResponse() { }

[kinuko, 2016/07/05 14:59:44]

Doesn't it cost us creating a WebURLRespnsePrivateImpl, which is going to be
disposed soon when it gets bound?

: WebURLResponse(&m_handle) ?

[Adam Rice, 2016/07/06 01:50:50]

I don't think it makes sense to have a default constructor on this class at all,
but unfortunately it is used by WebDataSourceImpl. I considered suboptimal
performance to be acceptable in that one case.

 
-    WrappedResourceResponse(ResourceResponse& resourceResponse)
+    explicit WrappedResourceResponse(ResourceResponse& resourceResponse)
+        : WebURLResponse(&m_handle)
+        , m_handle(&resourceResponse)
     {
-        bind(resourceResponse);
     }
 
-    WrappedResourceResponse(const ResourceResponse& resourceResponse)
+    explicit WrappedResourceResponse(const ResourceResponse& resourceResponse)
+        : WrappedResourceResponse(const_cast<ResourceResponse&>(resourceResponse))
     {
-        bind(resourceResponse);
-    }
-
-    void bind(ResourceResponse& resourceResponse)
-    {
-        m_handle.m_resourceResponse = &resourceResponse;
-        assign(&m_handle);
     }
 
     void bind(const ResourceResponse& resourceResponse)
     {
-        bind(*const_cast<ResourceResponse*>(&resourceResponse));
+        m_handle.m_resourceResponse = const_cast<ResourceResponse*>(&resourceResponse);
+        assign(&m_handle);
     }
 
 private:
     class Handle : public WebURLResponsePrivate {
         DISALLOW_NEW();
     public:
-        virtual void dispose() { m_resourceResponse = 0; }
+        Handle() {}
+        explicit Handle(ResourceResponse* resourceResponse)
+        {
+            m_resourceResponse = resourceResponse;
+        }
+        void dispose() override { m_resourceResponse = 0; }

[kinuko, 2016/07/05 15:42:11]

I don't feel I like this trick in general... I prefer more straightforward,
possibly more stupid solution like having a dumb boolean field in WebURLResponse
and let it delete if it's true.

     };
 
     Handle m_handle;
 };
 
 } // namespace blink
 
 #endif