Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Side by Side Diff: build/common.gypi

Issue 2120233002: Enable gold threaded link (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: +linux_use_bundled_binutils condition Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | build/config/compiler/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 4616 matching lines...) Expand 10 before | Expand all | Expand 10 after
4627 'defines': ['NO_TCMALLOC'], 4627 'defines': ['NO_TCMALLOC'],
4628 }], 4628 }],
4629 ['linux_use_gold_flags==1', { 4629 ['linux_use_gold_flags==1', {
4630 # Newer gccs and clangs support -fuse-ld, use the flag to force gold 4630 # Newer gccs and clangs support -fuse-ld, use the flag to force gold
4631 # selection. 4631 # selection.
4632 # gcc -- http://gcc.gnu.org/onlinedocs/gcc-4.8.0/gcc/Optimize-Option s.html 4632 # gcc -- http://gcc.gnu.org/onlinedocs/gcc-4.8.0/gcc/Optimize-Option s.html
4633 'ldflags': [ '-fuse-ld=gold', ], 4633 'ldflags': [ '-fuse-ld=gold', ],
4634 4634
4635 'target_conditions': [ 4635 'target_conditions': [
4636 ['_toolset=="target"', { 4636 ['_toolset=="target"', {
4637 'ldflags': [
4638 # Experimentation found that using four linking threads
4639 # saved ~20% of link time.
4640 # https://groups.google.com/a/chromium.org/group/chromium-dev/ browse_thread/thread/281527606915bb36
4641 # Only apply this to the target linker, since the host
4642 # linker might not be gold, but isn't used much anyway.
4643 # TODO(raymes): Disable threading because gold is frequently
4644 # crashing on the bots: crbug.com/161942.
4645 # '-Wl,--threads',
4646 # '-Wl,--thread-count=4',
4647 ],
4648 'conditions': [ 4637 'conditions': [
4649 # TODO(thestig): Enable this for disabled cases. 4638 # TODO(thestig): Enable this for disabled cases.
4639 [ 'linux_use_bundled_binutils==1', {
4640 'ldflags': [
4641 # Experimentation found that using four linking threads
4642 # saved ~20% of link time.
4643 # https://groups.google.com/a/chromium.org/group/chromium- dev/browse_thread/thread/281527606915bb36
4644 # Only apply this to the target linker, since the host
4645 # linker might not be gold, but isn't used much anyway.
4646 '-Wl,--threads',
4647 '-Wl,--thread-count=4',
4648 ],
4649 }],
4650 # TODO(thestig): Enable this for disabled cases.
4650 [ 'buildtype!="Official" and chromeos==0 and release_valgrind_ build==0 and asan==0 and lsan==0 and tsan==0 and msan==0 and ubsan==0 and ubsan_ security==0 and ubsan_vptr==0', { 4651 [ 'buildtype!="Official" and chromeos==0 and release_valgrind_ build==0 and asan==0 and lsan==0 and tsan==0 and msan==0 and ubsan==0 and ubsan_ security==0 and ubsan_vptr==0', {
4651 'ldflags': [ 4652 'ldflags': [
4652 '-Wl,--detect-odr-violations', 4653 '-Wl,--detect-odr-violations',
4653 ], 4654 ],
4654 }], 4655 }],
4655 ], 4656 ],
4656 }], 4657 }],
4657 ], 4658 ],
4658 'conditions': [ 4659 'conditions': [
4659 ['release_valgrind_build==0 and order_profiling==0 and asan==0 and msan==0 and lsan==0 and tsan==0', { 4660 ['release_valgrind_build==0 and order_profiling==0 and asan==0 and msan==0 and lsan==0 and tsan==0', {
(...skipping 1662 matching lines...) Expand 10 before | Expand all | Expand 10 after
6322 # settings in target dicts. SYMROOT is a special case, because many other 6323 # settings in target dicts. SYMROOT is a special case, because many other
6323 # Xcode variables depend on it, including variables such as 6324 # Xcode variables depend on it, including variables such as
6324 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6325 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6325 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6326 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6326 # files to appear (when present) in the UI as actual files and not red 6327 # files to appear (when present) in the UI as actual files and not red
6327 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6328 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6328 # and therefore SYMROOT, needs to be set at the project level. 6329 # and therefore SYMROOT, needs to be set at the project level.
6329 'SYMROOT': '<(DEPTH)/xcodebuild', 6330 'SYMROOT': '<(DEPTH)/xcodebuild',
6330 }, 6331 },
6331 } 6332 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | build/config/compiler/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698