Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 212023003: PPAPI: Bring PPB_MediaStream*Track to stable. (Closed)

Created:
6 years, 9 months ago by dmichael (off chromium)
Modified:
6 years, 8 months ago
Reviewers:
teravest
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, raymes+watch_chromium.org, teravest+watch_chromium.org, yzshen+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, binji, ihf+watch_chromium.org, Ronghua Wu (Left Chromium)
Visibility:
Public.

Description

PPAPI: Bring PPB_MediaStream*Track to stable. R=teravest@chromium.org TBR=binji BUG=330851, 353717 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260314

Patch Set 1 #

Patch Set 2 : Remove APIs from Dev Channel list #

Patch Set 3 : update documentation #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -66 lines) Patch
M native_client_sdk/src/examples/api/media_stream_audio/index.html View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M native_client_sdk/src/examples/api/media_stream_video/index.html View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/api/ppb_audio_buffer.idl View 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/api/ppb_media_stream_audio_track.idl View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M ppapi/api/ppb_media_stream_video_track.idl View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M ppapi/api/ppb_video_frame.idl View 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/c/ppb_audio_buffer.h View 4 chunks +7 lines, -3 lines 0 comments Download
M ppapi/c/ppb_media_stream_audio_track.h View 1 2 4 chunks +8 lines, -5 lines 0 comments Download
M ppapi/c/ppb_media_stream_video_track.h View 1 2 4 chunks +8 lines, -5 lines 0 comments Download
M ppapi/c/ppb_video_frame.h View 4 chunks +7 lines, -3 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 2 3 3 chunks +32 lines, -32 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev_channel.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_stable.h View 4 chunks +7 lines, -1 line 0 comments Download
M ppapi/thunk/ppb_media_stream_video_track_thunk.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dmichael (off chromium)
I need to take a pass over the APIs to make sure everything looks good ...
6 years, 9 months ago (2014-03-26 01:57:31 UTC) #1
teravest
The IDL changes look fine. As we discussed offline, you'll want to remove those interfaces ...
6 years, 9 months ago (2014-03-26 15:46:35 UTC) #2
teravest
On 2014/03/26 15:46:35, teravest wrote: > The IDL changes look fine. As we discussed offline, ...
6 years, 9 months ago (2014-03-27 19:12:28 UTC) #3
teravest
lgtm
6 years, 9 months ago (2014-03-27 19:12:39 UTC) #4
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 9 months ago (2014-03-28 22:26:28 UTC) #5
dmichael (off chromium)
The CQ bit was unchecked by dmichael@chromium.org
6 years, 9 months ago (2014-03-28 22:43:48 UTC) #6
dmichael (off chromium)
6 years, 9 months ago (2014-03-29 00:09:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r260314 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698