Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2120203002: X87: disable test-gap-resolver/FuzzResolver test case for x87. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: disable test-gap-resolver/FuzzResolver test case for x87. The reason: In CreateRandomOperand(), It used the register index 1 for ExplicitOperand(LocationOperand::REGISTER, rep, GetRegisterCode(rep, 1)). For x87 turbofan compiler, there's only 1 allocatable Float/Double register, i.e.: register index 0. the GetRegisterCode(rep, 1) in ExplicitOperand() always return false when rep is MachineRepresentation::kFloat32/kFloat64. It caused the test-gap-resolver/FuzzResolver failed at DCHECK_IMPLIES(kind == REGISTER && rep == MachineRepresentation::kFloat32, FloatRegister::from_code(index).IsAllocatable(RegisterConfiguration::TURBOFAN)), src/compiler/instruction.cc, line 259, under debug mode. This CL disable test-gap-resolver/FuzzResolver test case for x87. BUG= Committed: https://crrev.com/bf4ef548ccc6852e33b0b0bd30ad101a243f8ca6 Cr-Commit-Position: refs/heads/master@{#37515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/cctest/cctest.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-04 03:50:25 UTC) #2
titzer
On 2016/07/04 03:50:25, zhengxing.li wrote: > PTAL, thanks! lgtm
4 years, 5 months ago (2016-07-05 08:29:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120203002/1
4 years, 5 months ago (2016-07-05 08:31:48 UTC) #5
zhengxing.li
On 2016/07/05 08:29:09, titzer wrote: > On 2016/07/04 03:50:25, zhengxing.li wrote: > > PTAL, thanks! ...
4 years, 5 months ago (2016-07-05 08:31:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 08:54:50 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 08:54:52 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 08:56:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf4ef548ccc6852e33b0b0bd30ad101a243f8ca6
Cr-Commit-Position: refs/heads/master@{#37515}

Powered by Google App Engine
This is Rietveld 408576698