Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Unified Diff: third_party/WebKit/public/web/WebInputEvent.h

Issue 2120153003: Remove keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_key_identifier_3a
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebViewTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebInputEvent.h
diff --git a/third_party/WebKit/public/web/WebInputEvent.h b/third_party/WebKit/public/web/WebInputEvent.h
index d0375090964bfa4446a1c9f5bf17eeb2c809fc0b..98a1b1859e44e2986f8d50239b58d6681b4da2be 100644
--- a/third_party/WebKit/public/web/WebInputEvent.h
+++ b/third_party/WebKit/public/web/WebInputEvent.h
@@ -265,11 +265,6 @@ public:
// them PODs.
static const size_t textLengthCap = 4;
- // http://www.w3.org/TR/DOM-Level-3-Events/keyset.html lists the
- // identifiers. The longest is 18 characters, so we round up to the
- // next multiple of 4.
- static const size_t keyIdentifierLengthCap = 20;
-
// |windowsKeyCode| is the Windows key code associated with this key
// event. Sometimes it's direct from the event (i.e. on Windows),
// sometimes it's via a mapping function. If you want a list, see
@@ -314,9 +309,6 @@ public:
WebUChar text[textLengthCap];
WebUChar unmodifiedText[textLengthCap];
- // This is a string identifying the key pressed.
- char keyIdentifier[keyIdentifierLengthCap];
-
WebKeyboardEvent()
: WebInputEvent(sizeof(WebKeyboardEvent))
, windowsKeyCode(0)
@@ -326,12 +318,7 @@ public:
{
memset(&text, 0, sizeof(text));
memset(&unmodifiedText, 0, sizeof(unmodifiedText));
- memset(&keyIdentifier, 0, sizeof(keyIdentifier));
}
-
- // Sets keyIdentifier based on the value of windowsKeyCode. This is
- // handy for generating synthetic keyboard events.
- BLINK_COMMON_EXPORT void setKeyIdentifierFromWindowsKeyCode();
};
// WebMouseEvent --------------------------------------------------------------
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebViewTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698