third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent.html - Issue 2120153003: Remove keyIdentifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent.html

Issue 2120153003: Remove keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_key_identifier_3a

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js ('k') | third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent.html

diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent.html b/third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent.html

index 022e5ac061cdb78d52c540c3f9fd7ff673064cc2..34a61d45f22f48383cfe2e09bea1934bdaedcb62 100644

--- a/third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent.html

+++ b/third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent.html

@@ -21,8 +21,8 @@ function logEvent(event)

log("shiftKey");

if (event.keyCode)

log("keyCode: " + event.keyCode);

- if (event.keyIdentifier)

- log("keyIdentifier: " + event.keyIdentifier);

+ if (event.key)

+ log("key: " + event.key);

if (event.charCode)

log("charCode: " + event.charCode);

if (event.text)

@@ -36,7 +36,7 @@ function test()

{

"type": "rawKeyDown",

"windowsVirtualKeyCode": 65, // VK_A

- "keyIdentifier": "U+0041"

+ "key": "A"

{

"type": "char",

@@ -47,7 +47,7 @@ function test()

{

"type": "keyUp",

"windowsVirtualKeyCode": 65,

- "keyIdentifier": "U+0041"

+ "key": "A"

{

"type": "char",