third_party/WebKit/Source/web/tests/KeyboardTest.cpp - Issue 2120153003: Remove keyIdentifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/KeyboardTest.cpp

Issue 2120153003: Remove keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_key_identifier_3a

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/KeyboardTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/KeyboardTest.cpp b/third_party/WebKit/Source/web/tests/KeyboardTest.cpp

index bf1877e073a13821662d4e37287b8809c4d4f470..f785f6e65e6995a75bc7ca5b15930ba1cd06b933 100644

--- a/third_party/WebKit/Source/web/tests/KeyboardTest.cpp

+++ b/third_party/WebKit/Source/web/tests/KeyboardTest.cpp

@@ -68,7 +68,6 @@ public:

keyboardEvent->modifiers = modifiers;

keyboardEvent->type = WebInputEvent::KeyDown;

keyboardEvent->text[0] = keyCode;

- keyboardEvent->setKeyIdentifierFromWindowsKeyCode();

}

// Like interpretKeyEvent, but with pressing down OSModifier+|keyCode|.