third_party/WebKit/LayoutTests/fast/events/key-events-in-input-text.html - Issue 2120153003: Remove keyIdentifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/key-events-in-input-text.html

Issue 2120153003: Remove keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_key_identifier_3a

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/converters/blink/OWNERS ('K') | « third_party/WebKit/LayoutTests/fast/events/key-events-in-input-button-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/events/key-events-in-input-text-expected.txt » ('j') | third_party/WebKit/Source/core/frame/Deprecation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/key-events-in-input-text.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-text.html b/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-text.html

index 5a1e5eb27c9fab280963b22e9d36965da2b5b7b2..d5ef9c21b0de2ee8b32079bc135c6df60808f5ba 100644

--- a/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-text.html

+++ b/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-text.html

@@ -25,8 +25,8 @@ function eventInfo(event, where) {

else if (event.type == "keydown" || event.type == "keypress" || event.type == "keyup")

return (where ? "(" + where + ") " : "") + target.tagName + " - " + event.type

+ ' - ' + [event.ctrlKey, event.altKey, event.shiftKey, event.metaKey]

- + ' - ' + event.keyIdentifier

- + ' - ' + event.keyCode

+ + ' -' + event.key

+ + '- ' + event.keyCode

+ ' - ' + event.charCode

+ '. Value: "' + target.value + '".';

else if (event.type == "mousedown" || event.type == "click" || event.type == "mouseup")

@@ -38,7 +38,7 @@ function eventInfo(event, where) {

}

log("target - type - " + ["ctrlKey", "altKey", "shiftKey", "metaKey"]

- + ' - ' + "keyIdentifier"

+ + ' - ' + "key"

+ ' - ' + "keyCode"

+ ' - ' + "charCode");