third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor.html - Issue 2120153003: Remove keyIdentifier.

Unified Diff: third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor.html

Issue 2120153003: Remove keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_key_identifier_3a

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/converters/blink/OWNERS ('K') | « third_party/WebKit/LayoutTests/fast/events/arrow-keys-on-body-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt » ('j') | third_party/WebKit/Source/core/frame/Deprecation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor.html b/third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor.html

index 3a9f0d3d05e314ea0bb2d82203d73878da95cb3e..b24b2389124609b2bb85e9ca6a2b6fb2dceb7a51 100644

--- a/third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor.html

+++ b/third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor.html

@@ -16,7 +16,6 @@ shouldBe("new KeyboardEvent('eventType').bubbles", "false");

shouldBe("new KeyboardEvent('eventType').cancelable", "false");

shouldBe("new KeyboardEvent('eventType').view", "null");

shouldBe("new KeyboardEvent('eventType').detail", "0");

-shouldBeEqualToString("new KeyboardEvent('eventType').keyIdentifier", "");

shouldBe("new KeyboardEvent('eventType').location", "0");

shouldBe("new KeyboardEvent('eventType').ctrlKey", "false");

shouldBe("new KeyboardEvent('eventType').altKey", "false");

@@ -55,24 +54,6 @@ shouldBe("new KeyboardEvent('eventType', { get view() { return window; } }).view

shouldThrow("new KeyboardEvent('eventType', { get view() { return 123; } }).view");

shouldThrow("new KeyboardEvent('eventType', { get view() { throw 'KeyboardEvent Error'; } })");

-// keyIdentifier is passed.

-// Strings.

-shouldBeEqualToString("new KeyboardEvent('eventType', { keyIdentifier: 'koakuma' }).keyIdentifier", "koakuma");

-shouldBeEqualToString("new KeyboardEvent('eventType', { keyIdentifier: '' }).keyIdentifier", "");

-// Non-strings.

-shouldBeEqualToString("new KeyboardEvent('eventType', { keyIdentifier: undefined }).keyIdentifier", "");

-shouldBeEqualToString("new KeyboardEvent('eventType', { keyIdentifier: null }).keyIdentifier", "null");

-shouldBeEqualToString("new KeyboardEvent('eventType', { keyIdentifier: false }).keyIdentifier", "false");

-shouldBeEqualToString("new KeyboardEvent('eventType', { keyIdentifier: true }).keyIdentifier", "true");

-shouldBeEqualToString("new KeyboardEvent('eventType', { keyIdentifier: 12345 }).keyIdentifier", "12345");

-shouldBeEqualToString("new KeyboardEvent('eventType', { keyIdentifier: 18446744073709551615 }).keyIdentifier", "18446744073709552000");

-shouldBeEqualToString("new KeyboardEvent('eventType', { keyIdentifier: NaN }).keyIdentifier", "NaN");

-shouldBeEqualToString("new KeyboardEvent('eventType', { keyIdentifier: [] }).keyIdentifier", "");

-shouldBeEqualToString("new KeyboardEvent('eventType', { keyIdentifier: [1, 2, 3] }).keyIdentifier", "1,2,3");

-shouldBeEqualToString("new KeyboardEvent('eventType', { keyIdentifier: {koakuma: 12345} }).keyIdentifier", "[object Object]");

-shouldBeEqualToString("new KeyboardEvent('eventType', { keyIdentifier: {valueOf: function () { return 'koakuma'; } } }).keyIdentifier", "[object Object]");

// code is passed.

// Strings.

shouldBeEqualToString("new KeyboardEvent('eventType', { code: 'koakuma' }).code", "koakuma");

@@ -153,19 +134,18 @@ forEachModifier(function(attr, modifierName) {

});

// All initializers are passed.

-shouldBe("new KeyboardEvent('eventType', { bubbles: true, cancelable: true, view: window, detail: 111, keyIdentifier: 'chocolate', code: 'chocode', key: 'chokey', location: 222, ctrlKey: true, altKey: true, shiftKey: true, metaKey: true, repeat: true }).bubbles", "true");

-shouldBeEqualToString("new KeyboardEvent('eventType', { bubbles: true, cancelable: true, view: window, detail: 111, keyIdentifier: 'chocolate', code: 'chocode', key: 'chokey', location: 222, ctrlKey: true, altKey: true, shiftKey: true, metaKey: true, repeat: true }).keyIdentifier", "chocolate");

+shouldBe("new KeyboardEvent('eventType', { bubbles: true, cancelable: true, view: window, detail: 111, code: 'chocode', key: 'chokey', location: 222, ctrlKey: true, altKey: true, shiftKey: true, metaKey: true, repeat: true }).bubbles", "true");

+shouldBeEqualToString("new KeyboardEvent('eventType', { bubbles: true, cancelable: true, view: window, detail: 111, code: 'chocode', key: 'chokey', location: 222, ctrlKey: true, altKey: true, shiftKey: true, metaKey: true, repeat: true }).code", "chocode");

</script>

</body>

</html>