Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2120133002: Revert of The PROCESSKEY event triggered by IME should not carry the real DomKey/DomCode to avoid wrongly pro… (Closed)

Created:
4 years, 5 months ago by Shu Chen
Modified:
4 years, 5 months ago
Reviewers:
James Su
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of The PROCESSKEY event triggered by IME should not carry the real DomKey/DomCode to avoid wrongly pro… (patchset #3 id:40001 of https://codereview.chromium.org/2072213003/ ) Reason for revert: Refer to comment #10 of crbug.com/620794: The fix for this breaks dead key information for the fabricated key events. Original issue's description: > The PROCESSKEY event triggered by IME should not carry the real DomKey/DomCode to avoid wrongly processing by chrome. > > BUG=620794 > > Committed: https://crrev.com/c87c4c1db691498c68b73794769ab5e4d0fc3417 > Cr-Commit-Position: refs/heads/master@{#400421} TBR=suzhe@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=620794 Committed: https://crrev.com/aad5b1b1de80ef24ea5b8bea75dabf3b8e39dc1f Cr-Commit-Position: refs/heads/master@{#403625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/base/ime/input_method_chromeos.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/base/ime/input_method_chromeos_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
Shu Chen
4 years, 5 months ago (2016-07-03 10:48:53 UTC) #2
Created Revert of The PROCESSKEY event triggered by IME should not carry the
real DomKey/DomCode to avoid wrongly pro…

Powered by Google App Engine
This is Rietveld 408576698