Enable stricter pylint checks.

third_party/WebKit/Tools/Scripts/webkitpy/pylintrc

Index: third_party/WebKit/Tools/Scripts/webkitpy/pylintrc
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc b/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc
index 284bffe1eb9f555b5e6553bfae85924e5670b7a2..d0b5f554703e4e0fc677c302046df7d209c95f52 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc
@@ -26,8 +26,6 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-# FIXME: remove this whitespace diff.
-#
 [MASTER]
 
 # Specify a configuration file.
@@ -63,45 +61,20 @@ load-plugins=
 # can either give multiple identifier separated by comma (,) or put this option
 # multiple time (only on the command line, not in the configuration file where
 # it should appear only once).
-# CHANGED:
 disable=
-  invalid-name,
-  missing-docstring,
-  line-too-long,
-  too-many-lines,
-  bad-inline-option,
+  design,

[qyearsley, 2016/07/03 17:20:10]

design covers all of the "too-many-x" warnings.

+  fixme,
+  global-statement,
   locally-disabled,
-  no-self-use,
-  duplicate-code,
-  too-many-ancestors,
-  too-many-instance-attributes,
-  too-few-public-methods,
-  too-many-public-methods,
-  too-many-return-statements,
-  too-many-branches,
-  too-many-arguments,
-  too-many-locals,
-  too-many-statements,
-  abstract-class-not-used,
-  abstract-class-little-used,
-  exec-used,
-  bad-builtin,
+  missing-docstring,
   star-args,
-  protected-access,
   wildcard-import,
-  deprecated-module,
-  reimported,
-  fixme,
-  global-statement,
-  unused-wildcard-import,
-  broad-except,
-  logging-not-lazy,
 
 
 [REPORTS]
 
 # Set the output format. Available formats are text, parseable, colorized, msvs
-# (visual studio) and html
+# (visual studio) and html.
 output-format=text
 
 # Put messages in a separate file for each module / package specified on the
@@ -109,8 +82,7 @@ output-format=text
 # written in a file name "pylint_global.[txt|html]".
 files-output=no
 
-# Tells whether to display a full report or only the messages
-# CHANGED:
+# Tells whether to display a full report or only the messages.
 reports=no
 
 # Python expression which should return a note less than 10 (10 is the highest
@@ -180,61 +152,59 @@ ignore-docstrings=yes
 [FORMAT]
 
 # Maximum number of characters on a single line.
-max-line-length=200
+max-line-length=132
 
-# Maximum number of lines in a module
-max-module-lines=1000
+# Maximum number of lines in a module.
+max-module-lines=4000

[qyearsley, 2016/07/03 17:20:10]

Enabled line-too-long and file-too-long warnings, so these numbers are now
significant.

Reason for the number 4000 is: checkers/cpp.py is around 4000 lines. We could
reduce this number later.

 
-# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1
-# tab).
-# CHANGED:
+# String used as indentation unit. This is usually 4 spaces 1 tab.
 indent-string='    '
 
 
 [BASIC]
 
-# Required attributes for module, separated by a comma
+# Required attributes for module, separated by a comma.
 required-attributes=
 
-# List of builtins function names that should not be used, separated by a comma
-bad-functions=map,filter,apply,input
+# List of builtins function names that should not be used, separated by a comma.
+bad-functions=apply

[qyearsley, 2016/07/03 17:20:10]

The map and filter functions appear in this codebase sometimes, and I think
they're generally accepted. We could add more functions to this list though.

 
-# Regular expression which should only match correct module names
-module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
+# Regular expression which should only match correct module names.
+module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+)|([a-z-][a-z0-9-]*))$

[qyearsley, 2016/07/03 17:20:10]

The scripts in Tools/Scripts have file names with dashes; to avoid pylint
complaining about these, I added a regex for lower case with dashes.

 
-# Regular expression which should only match correct module level names
+# Regular expression which should only match correct module level names.
 const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$
 
-# Regular expression which should only match correct class names
+# Regular expression which should only match correct class names.
 class-rgx=[A-Z_][a-zA-Z0-9]+$
 
-# Regular expression which should only match correct function names
+# Regular expression which should only match correct function names.
 function-rgx=[a-z_][a-z0-9_]{2,30}$
 
-# Regular expression which should only match correct method names
+# Regular expression which should only match correct method names.
 method-rgx=[a-z_][a-z0-9_]{2,30}$
 
-# Regular expression which should only match correct instance attribute names
-attr-rgx=[a-z_][a-z0-9_]{2,30}$
+# Regular expression which should only match correct instance attribute names.
+attr-rgx=[a-z_][a-z0-9_]{1,30}$
 
-# Regular expression which should only match correct argument names
-argument-rgx=[a-z_][a-z0-9_]{2,30}$
+# Regular expression which should only match correct argument names.
+argument-rgx=[a-z_][a-z0-9_]{1,30}$
 
-# Regular expression which should only match correct variable names
-variable-rgx=[a-z_][a-z0-9_]{2,30}$
+# Regular expression which should only match correct variable names.
+variable-rgx=[a-z_][a-z0-9_]{1,30}$
 
 # Regular expression which should only match correct list comprehension /
-# generator expression variable names
+# generator expression variable names.
 inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$
 
-# Good variable names which should always be accepted, separated by a comma
-good-names=i,j,k,ex,Run,_
+# Good variable names which should always be accepted, separated by a comma.
+good-names=i,j,k,ex,Run,_,_log

[qyearsley, 2016/07/03 17:20:10]

_log is used as a constant name frequently in this codebase, which is OK.

 
-# Bad variable names which should always be refused, separated by a comma
+# Bad variable names which should always be refused, separated by a comma.
 bad-names=foo,bar,baz,toto,tutu,tata
 
 # Regular expression which should only match functions or classes name which do
-# not require a docstring
+# not require a docstring.
 no-docstring-rgx=__.*__
 
 
@@ -243,20 +213,19 @@ no-docstring-rgx=__.*__
 # Maximum number of arguments for function / method
 max-args=5
 
-# Argument names that match this expression will be ignored. Default to name
-# with leading underscore
+# Argument names that match this expression will be ignored.
 ignored-argument-names=_.*
 
-# Maximum number of locals for function / method body
+# Maximum number of locals for function / method body.

[mithro, 2016/07/21 05:37:54]

I don't think we should change all the comment lines in this CL.

[qyearsley, 2016/07/21 16:04:51]

Comment changes now removed from this CL

 max-locals=15
 
-# Maximum number of return / yield for function / method body
+# Maximum number of return / yield for function / method body.
 max-returns=6
 
-# Maximum number of branch for function / method body
+# Maximum number of branch for function / method body.
 max-branchs=12
 
-# Maximum number of statements in function / method body
+# Maximum number of statements in function / method body.
 max-statements=50
 
 # Maximum number of parents for a class (see R0901).