Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2120063002: Revert zone tasks. (Closed)

Created:
4 years, 5 months ago by floitsch
Modified:
4 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert zone tasks. Revert "Add tasks to zones." This reverts commit 85cccde71792a0e2920bd8e2d4ebf73880355940. Revert "Make Dom events run through zone tasks." This reverts commit 6d1f6b2af65636cfe307f81e9d8ded997573c035. Revert "Add zone task support for request-anim." This reverts commit 726b9f8dc73b9a279ed6eb8bfff51ed091a4395b. Revert "Add zone task support to http-requests." This reverts commit b40cfcb57fa8d1890358f026d2c3f014909b2240. Revert "Update status file for jsshell." This reverts commit 5e05ee9b5ff2cf88c4601376e3cf331cede163e4. Committed: https://github.com/dart-lang/sdk/commit/34d3c37233f3beb6d1dfb5b23d23c0a674419661

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -3898 lines) Patch
M sdk/lib/async/timer.dart View 3 chunks +8 lines, -139 lines 0 comments Download
M sdk/lib/async/zone.dart View 32 chunks +64 lines, -351 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 21 chunks +50 lines, -431 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 20 chunks +49 lines, -400 lines 0 comments Download
D tests/html/event_subscription_specification_test.dart View 1 chunk +0 lines, -121 lines 0 comments Download
D tests/html/event_zone_task_test.dart View 1 chunk +0 lines, -239 lines 0 comments Download
D tests/html/request_animation_task_test.dart View 1 chunk +0 lines, -170 lines 0 comments Download
D tests/html/xhr_task2_test.dart View 1 chunk +0 lines, -280 lines 0 comments Download
D tests/html/xhr_task_test.dart View 1 chunk +0 lines, -508 lines 0 comments Download
D tests/lib/async/zone_task_test.dart View 1 chunk +0 lines, -310 lines 0 comments Download
D tests/lib/async/zone_timer_task_test.dart View 1 chunk +0 lines, -515 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/docs/docs.json View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 9 chunks +16 lines, -99 lines 0 comments Download
M tools/dom/src/shared_html.dart View 1 chunk +19 lines, -14 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 4 chunks +5 lines, -125 lines 0 comments Download
M tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate View 6 chunks +8 lines, -190 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
TBR. Failing tests: Probably just a typing error (checked mode): Test failed: Caught type '(HttpRequest) ...
4 years, 5 months ago (2016-07-02 05:36:13 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as 34d3c37233f3beb6d1dfb5b23d23c0a674419661 (presubmit successful).
4 years, 5 months ago (2016-07-02 05:37:01 UTC) #4
Lasse Reichstein Nielsen
4 years, 5 months ago (2016-07-04 11:01:26 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698