Hide web notification tray when LoginStatus is locked

Hide web notification tray when LoginStatus is locked

BUG=625357
TEST=manual test: locked screen state will see web notification tray be hidden and shown when logged in

Committed: https://crrev.com/198e264eb577cab76a6cb13d1d8b4b5d0135cb3c
Cr-Commit-Position: refs/heads/master@{#403955}

[Qiang(Joe) Xu, 2016-07-02 01:22:04]

Description was changed from

==========
Hide web notification tray when LoginStatus is locked

BUG=625357
TEST=manual test: locked screen state will see web notification tray be hidden
and shown when logged in
==========

to

==========
Hide web notification tray when LoginStatus is locked

BUG=625357
TEST=manual test: locked screen state will see web notification tray be hidden
and shown when logged in
==========

[Qiang(Joe) Xu, 2016-07-02 01:22:05]

warx@chromium.org changed reviewers:
+ jamescook@chromium.org

[Qiang(Joe) Xu, 2016-07-02 01:24:33]

Hi James, could you help take a look, thanks! This bug has another solution
which is enabling activating like what system tray does. Please let me know
which one you prefer.

[Qiang(Joe) Xu, 2016-07-02 01:24:40]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-02 01:25:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-02 02:07:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-02 02:07:33]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-07-02 03:11:14]

On 2016/07/02 02:07:33, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

What do you mean by "enabling activating like what system tray does"?

Also, do you have a call stack for the crash?

(I think this fix is probably fine, but I would like to know a little bit more.)

[Qiang(Joe) Xu, 2016-07-02 03:30:57]

On 2016/07/02 03:11:14, James Cook wrote:
> On 2016/07/02 02:07:33, commit-bot: I haz the power wrote:
> > Dry run: This issue passed the CQ dry run.
> 
> What do you mean by "enabling activating like what system tray does"?
> 
> Also, do you have a call stack for the crash?
> 
> (I think this fix is probably fine, but I would like to know a little bit
more.)

I mean show "web notification tray contents" in account picker screen when
clicked, like showing deprecated shortcut notification, screenshot notification.
This will be a more involved fix but not quite necessary I think.

On desktop build, it shows these only:

Cannot upload crash dump: cannot exec /sbin/crash_reporter

System crash-reporter failed to process crash report.
Report Id: 
Segmentation fault (core dumped)

Where can I find the logs? I checked file:///var/log/, not sure where are they.

[James Cook, 2016-07-02 21:15:15]

On 2016/07/02 03:30:57, Qiang (Joe) Xu wrote:
> > (I think this fix is probably fine, but I would like to know a little bit
> more.)
> 
> I mean show "web notification tray contents" in account picker screen when
> clicked, like showing deprecated shortcut notification, screenshot
notification.
> This will be a more involved fix but not quite necessary I think.
> 
> On desktop build, it shows these only:
> 
> Cannot upload crash dump: cannot exec /sbin/crash_reporter
> 
> System crash-reporter failed to process crash report.
> Report Id: 
> Segmentation fault (core dumped)
> 
> Where can I find the logs? I checked file:///var/log/, not sure where are
they.

By "desktop build" I presume you mean a linux build running on Goobuntu with
target_os = "chromeos". If you do a debug build, and run with --no-sandbox, you
should get a stack trace printed to the console when it crashes.

I think the logs go in /var/log/messages and/or /var/log/ui but I don't have a
dev build machine in front of me to verify.

On 51 stable the notification tray does not show at the lock screen, so this fix
is probably OK. However, I want to check with the ARC++ people to be sure they
didn't change that behavior. I'll send email and CC you.

[Qiang(Joe) Xu, 2016-07-06 16:44:06]

On 2016/07/02 21:15:15, James Cook wrote:
> On 2016/07/02 03:30:57, Qiang (Joe) Xu wrote:
> > > (I think this fix is probably fine, but I would like to know a little bit
> > more.)
> > 
> > I mean show "web notification tray contents" in account picker screen when
> > clicked, like showing deprecated shortcut notification, screenshot
> notification.
> > This will be a more involved fix but not quite necessary I think.
> > 
> > On desktop build, it shows these only:
> > 
> > Cannot upload crash dump: cannot exec /sbin/crash_reporter
> > 
> > System crash-reporter failed to process crash report.
> > Report Id: 
> > Segmentation fault (core dumped)
> > 
> > Where can I find the logs? I checked file:///var/log/, not sure where are
> they.
> 
> By "desktop build" I presume you mean a linux build running on Goobuntu with
> target_os = "chromeos". If you do a debug build, and run with --no-sandbox,
you
> should get a stack trace printed to the console when it crashes.
> 
> I think the logs go in /var/log/messages and/or /var/log/ui but I don't have a
> dev build machine in front of me to verify.
> 
> On 51 stable the notification tray does not show at the lock screen, so this
fix
> is probably OK. However, I want to check with the ARC++ people to be sure they
> didn't change that behavior. I'll send email and CC you.

Hi, on chromebook, /var/log/ui prints pretty the same contents:

_sys_cr_finished
System crash-reporter failed to process crash report.
Report Id:

No more details are shown.

[James Cook, 2016-07-06 17:48:16]

On 2016/07/06 16:44:06, Qiang (Joe) Xu wrote:
> On 2016/07/02 21:15:15, James Cook wrote:
> > On 2016/07/02 03:30:57, Qiang (Joe) Xu wrote:
> > > > (I think this fix is probably fine, but I would like to know a little
bit
> > > more.)
> > > 
> > > I mean show "web notification tray contents" in account picker screen when
> > > clicked, like showing deprecated shortcut notification, screenshot
> > notification.
> > > This will be a more involved fix but not quite necessary I think.
> > > 
> > > On desktop build, it shows these only:
> > > 
> > > Cannot upload crash dump: cannot exec /sbin/crash_reporter
> > > 
> > > System crash-reporter failed to process crash report.
> > > Report Id: 
> > > Segmentation fault (core dumped)
> > > 
> > > Where can I find the logs? I checked file:///var/log/, not sure where are
> > they.
> > 
> > By "desktop build" I presume you mean a linux build running on Goobuntu with
> > target_os = "chromeos". If you do a debug build, and run with --no-sandbox,
> you
> > should get a stack trace printed to the console when it crashes.
> > 
> > I think the logs go in /var/log/messages and/or /var/log/ui but I don't have
a
> > dev build machine in front of me to verify.
> > 
> > On 51 stable the notification tray does not show at the lock screen, so this
> fix
> > is probably OK. However, I want to check with the ARC++ people to be sure
they
> > didn't change that behavior. I'll send email and CC you.
> 
> Hi, on chromebook, /var/log/ui prints pretty the same contents:
> 
> _sys_cr_finished
> System crash-reporter failed to process crash report.
> Report Id:
> 
> No more details are shown.

Can you repro the crash on a desktop linux target_os="chromeos" build?

[Qiang(Joe) Xu, 2016-07-06 17:51:04]

On 2016/07/06 17:48:16, James Cook wrote:
> On 2016/07/06 16:44:06, Qiang (Joe) Xu wrote:
> > On 2016/07/02 21:15:15, James Cook wrote:
> > > On 2016/07/02 03:30:57, Qiang (Joe) Xu wrote:
> > > > > (I think this fix is probably fine, but I would like to know a little
> bit
> > > > more.)
> > > > 
> > > > I mean show "web notification tray contents" in account picker screen
when
> > > > clicked, like showing deprecated shortcut notification, screenshot
> > > notification.
> > > > This will be a more involved fix but not quite necessary I think.
> > > > 
> > > > On desktop build, it shows these only:
> > > > 
> > > > Cannot upload crash dump: cannot exec /sbin/crash_reporter
> > > > 
> > > > System crash-reporter failed to process crash report.
> > > > Report Id: 
> > > > Segmentation fault (core dumped)
> > > > 
> > > > Where can I find the logs? I checked file:///var/log/, not sure where
are
> > > they.
> > > 
> > > By "desktop build" I presume you mean a linux build running on Goobuntu
with
> > > target_os = "chromeos". If you do a debug build, and run with
--no-sandbox,
> > you
> > > should get a stack trace printed to the console when it crashes.
> > > 
> > > I think the logs go in /var/log/messages and/or /var/log/ui but I don't
have
> a
> > > dev build machine in front of me to verify.
> > > 
> > > On 51 stable the notification tray does not show at the lock screen, so
this
> > fix
> > > is probably OK. However, I want to check with the ARC++ people to be sure
> they
> > > didn't change that behavior. I'll send email and CC you.
> > 
> > Hi, on chromebook, /var/log/ui prints pretty the same contents:
> > 
> > _sys_cr_finished
> > System crash-reporter failed to process crash report.
> > Report Id:
> > 
> > No more details are shown.
> 
> Can you repro the crash on a desktop linux target_os="chromeos" build?

Yes, I can. And the console log is the same, which is message #9.

[James Cook, 2016-07-06 20:37:43]

LGTM. Go ahead and land this so we get the crash fixed. Later we can sort out
whether or not we want to show the icon. Please also get this backported to M53
(I can help with that if you need it). Thanks!

[Qiang(Joe) Xu, 2016-07-06 20:40:24]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2016-07-06 20:41:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 21:21:40]

Description was changed from

==========
Hide web notification tray when LoginStatus is locked

BUG=625357
TEST=manual test: locked screen state will see web notification tray be hidden
and shown when logged in
==========

to

==========
Hide web notification tray when LoginStatus is locked

BUG=625357
TEST=manual test: locked screen state will see web notification tray be hidden
and shown when logged in
==========

[commit-bot: I haz the power, 2016-07-06 21:21:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-06 21:21:50]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-06 21:23:52]

Description was changed from

==========
Hide web notification tray when LoginStatus is locked

BUG=625357
TEST=manual test: locked screen state will see web notification tray be hidden
and shown when logged in
==========

to

==========
Hide web notification tray when LoginStatus is locked

BUG=625357
TEST=manual test: locked screen state will see web notification tray be hidden
and shown when logged in

Committed: https://crrev.com/198e264eb577cab76a6cb13d1d8b4b5d0135cb3c
Cr-Commit-Position: refs/heads/master@{#403955}
==========

[commit-bot: I haz the power, 2016-07-06 21:23:53]

Patchset 1 (id:??) landed as
https://crrev.com/198e264eb577cab76a6cb13d1d8b4b5d0135cb3c
Cr-Commit-Position: refs/heads/master@{#403955}