Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2287)

Issue 212003002: Re-land: content: Avoid duplicating the logic used to determine GPU features. (Closed)

Created:
6 years, 9 months ago by reveman
Modified:
6 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

Re-land: content: Avoid duplicating the logic used to determine GPU features. For features that need to be determined if used in the browser, keep all the logic on browser side rather than duplicating it in the renderer. BUG=354449 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260311

Patch Set 1 #

Patch Set 2 : Use IsDelegatedRendererEnabled in RenderWidgetHostViewAndroid #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M content/browser/gpu/compositor_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 7 chunks +6 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 chunks +2 lines, -4 lines 1 comment Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
reveman
6 years, 9 months ago (2014-03-26 01:24:25 UTC) #1
piman
LGTM, nice cleanup.
6 years, 9 months ago (2014-03-26 02:15:58 UTC) #2
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 9 months ago (2014-03-26 03:15:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/212003002/1
6 years, 9 months ago (2014-03-26 03:15:47 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 04:52:53 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=288089
6 years, 9 months ago (2014-03-26 04:52:53 UTC) #6
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 9 months ago (2014-03-26 09:27:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/212003002/1
6 years, 9 months ago (2014-03-26 09:27:57 UTC) #8
commit-bot: I haz the power
Change committed as 259543
6 years, 9 months ago (2014-03-26 10:20:36 UTC) #9
vsevik
A revert of this CL has been created in https://codereview.chromium.org/212863004/ by vsevik@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-26 13:30:12 UTC) #10
reveman
Verified that latest patch doesn't cause the same crash. Re-landing. https://codereview.chromium.org/212003002/diff/350001/content/browser/renderer_host/render_widget_host_view_android.cc File content/browser/renderer_host/render_widget_host_view_android.cc (right): https://codereview.chromium.org/212003002/diff/350001/content/browser/renderer_host/render_widget_host_view_android.cc#newcode156 ...
6 years, 9 months ago (2014-03-28 16:50:32 UTC) #11
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 9 months ago (2014-03-28 16:50:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/212003002/350001
6 years, 9 months ago (2014-03-28 16:54:13 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 23:44:33 UTC) #14
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-03-28 23:44:34 UTC) #15
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 8 months ago (2014-03-28 23:51:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/212003002/350001
6 years, 8 months ago (2014-03-28 23:55:37 UTC) #17
commit-bot: I haz the power
6 years, 8 months ago (2014-03-29 00:06:06 UTC) #18
Message was sent while issue was closed.
Change committed as 260311

Powered by Google App Engine
This is Rietveld 408576698