Issue 2120003002: Fixes mash

Issue 2120003002: Fixes mash (Closed)

Created:
4 years, 5 months ago by sky

Modified:
4 years, 5 months ago

Reviewers:
James Cook

CC:
chromium-reviews, kalyank, sadrul

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fixes mash Turns out maximize controller uses dbus, which we aren't yet creating. Temporarily disable mojo:ash from creating maximize controller until sorted out. BUG=612629 TEST=covered by tests R=jamescook@chromium.org TBR=jamescook@chromium.org Committed: https://crrev.com/3469a6d1b37bed86a1f08ada6c3e350a236158ba Cr-Commit-Position: refs/heads/master@{#403563}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	ash/mus/bridge/wm_shell_mus.cc	View		2 chunks	+0 lines, -5 lines	0 comments	Download

Total messages: 10 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120003002/1

4 years, 5 months ago (2016-07-01 22:48:27 UTC) #4

James Cook

LGTM. It might not be that hard to init the dbus stuff for real, see ...

4 years, 5 months ago (2016-07-01 22:59:29 UTC) #5

sky

On 2016/07/01 22:59:29, James Cook wrote: > LGTM. It might not be that hard to ...

4 years, 5 months ago (2016-07-01 23:03:13 UTC) #6

commit-bot: I haz the power

4 years, 5 months ago (2016-07-01 23:47:11 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3469a6d1b37bed86a1f08ada6c3e350a236158ba
Cr-Commit-Position: refs/heads/master@{#403563}