Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2119983002: Mac: Improve font substitution. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Mac: Improve font substitution. Take the requested font weight and italicization into account when searching for fonts. For example, for a font with the face "Arial" and a weight of 700, search to see if "Arial Bold" is available. BUG=530 Committed: https://pdfium.googlesource.com/pdfium/+/cfb31d67a40310ed64d942ba346cf0cd3a01cadf

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M core/fxge/apple/fx_mac_imp.cpp View 1 1 chunk +18 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Lei Zhang
4 years, 7 months ago (2016-07-01 22:06:29 UTC) #2
Wei Li
lgtm
4 years, 7 months ago (2016-07-01 23:14:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119983002/20001
4 years, 7 months ago (2016-07-01 23:52:35 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-07-01 23:52:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/cfb31d67a40310ed64d942ba346cf0cd3a01...

Powered by Google App Engine
This is Rietveld 408576698