Port WebSockets to Mojo IPC

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 4245 matching lines @@
   }
   ChildThreadImpl::current()->quota_dispatcher()->RequestStorageQuota(
       render_view_->GetRoutingID(),
       blink::WebStringToGURL(origin.toString()),
       static_cast<storage::StorageType>(type),
       requested_size,
       QuotaDispatcher::CreateWebStorageQuotaCallbacksWrapper(callbacks));
 }
 
 void RenderFrameImpl::willOpenWebSocket(blink::WebSocketHandle* handle) {
-  WebSocketBridge* impl = static_cast<WebSocketBridge*>(handle);
-  impl->set_render_frame_id(routing_id_);
+  static_cast<WebSocketBridge*>(handle)->Initialize(GetServiceRegistry());

[Ben Goodger (Google), 2016/07/01 21:19:51]

Do you have an opinion about whether it'd be better to pass the registry in
here, or the WebSocketPtr?

It's a bit murky for the frame registry.. but for shell::Connection registries
I've been trying to avoid passing the connection/connectors around into feature
code since any GetInterface() call will have to be understood by the embedder &
reflected in its manifest. In practice this is not an issue for content today,
but may be eventually.

[darin (slow to review), 2016/07/06 16:57:21]

Good question. I'm not sure what is better.

 
One thing that is nice about passing the InterfaceProvider into the
WebSocketBridge is that it allows the details of how a WebSocket is acquired to
be contained in the WebSocketBridge code. The consumer of the WebSocketBridge
doesn't have to know those details. Admittedly, this is a fairly trivial example
as that isn't a complicated detail. It may be more interesting in other cases
though?

 }
 
 blink::WebPresentationClient* RenderFrameImpl::presentationClient() {
   if (!presentation_dispatcher_)
     presentation_dispatcher_ = new PresentationDispatcher(this);
   return presentation_dispatcher_;
 }
 
 blink::WebPushClient* RenderFrameImpl::pushClient() {
   if (!push_messaging_dispatcher_)
@@ skipping 1977 matching lines @@
   // event target. Potentially a Pepper plugin will receive the event.
   // In order to tell whether a plugin gets the last mouse event and which it
   // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
   // the event, it will notify us via DidReceiveMouseEvent() and set itself as
   // |pepper_last_mouse_event_target_|.
   pepper_last_mouse_event_target_ = nullptr;
 #endif
 }
 
 }  // namespace content