Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2119913002: Fix flaky Kiosk browser_tests failing on wrong widget opacity. (Closed)

Created:
4 years, 5 months ago by afakhry
Modified:
4 years, 5 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky Kiosk browser_tests failing on wrong widget opacity. Ash was trying to show the shelf with its widget opacity set to 0.0 causing a DCHECK crash in the tests. This makes sure the opacity of the system tray's widget is set properly when it's shown or hidden. Also re-enables a test that was disabled previously since it's passing now due to this CL. BUG=624584 TEST=browser_tests --gtest_filter=KioskEnterpriseTest.PrivateStore TEST=browser_tests --gtest_filter=KioskUpdateTest.IncompliantPlatformFirstInstall Committed: https://crrev.com/1828054aceaf6bc19e5ac5c5bc49689c47930df3 Cr-Commit-Position: refs/heads/master@{#403489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
afakhry
Xiyuan, please review. Thank you!
4 years, 5 months ago (2016-07-01 17:55:17 UTC) #2
xiyuan
lgtm
4 years, 5 months ago (2016-07-01 18:04:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119913002/1
4 years, 5 months ago (2016-07-01 18:06:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 18:34:23 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 18:37:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1828054aceaf6bc19e5ac5c5bc49689c47930df3
Cr-Commit-Position: refs/heads/master@{#403489}

Powered by Google App Engine
This is Rietveld 408576698