Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2119903002: fixed SkSL memory leak (Closed)

Created:
4 years, 5 months ago by ethannicholas
Modified:
4 years, 5 months ago
Reviewers:
dogben
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/sksl/SkSLParser.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 33 (17 generated)
ethannicholas
4 years, 5 months ago (2016-07-01 17:52:39 UTC) #3
dogben
lgtm
4 years, 5 months ago (2016-07-01 17:58:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119903002/1
4 years, 5 months ago (2016-07-01 18:00:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/9493)
4 years, 5 months ago (2016-07-01 18:09:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119903002/1
4 years, 5 months ago (2016-07-01 18:33:48 UTC) #10
dogben
On 2016/07/01 18:33:48, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 5 months ago (2016-07-01 18:43:44 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119903002/1
4 years, 5 months ago (2016-07-01 18:46:51 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/9497)
4 years, 5 months ago (2016-07-01 18:54:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119903002/1
4 years, 5 months ago (2016-07-01 19:38:50 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/9503)
4 years, 5 months ago (2016-07-01 19:50:21 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119903002/1
4 years, 5 months ago (2016-07-01 22:58:34 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/9539)
4 years, 5 months ago (2016-07-01 23:06:32 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119903002/1
4 years, 5 months ago (2016-07-02 01:53:53 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119903002/1
4 years, 5 months ago (2016-07-02 02:08:31 UTC) #30
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/69a7e7c310f940679d3086c15faf17dca652b684
4 years, 5 months ago (2016-07-02 02:09:32 UTC) #32
commit-bot: I haz the power
4 years, 5 months ago (2016-07-02 02:09:34 UTC) #33
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698