Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2119883002: SkPDF: fix PDFA-only metadata error (Closed)

Created:
4 years, 5 months ago by hal.canary
Modified:
4 years, 5 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pdf/SkPDFMetadata.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119883002/1
4 years, 5 months ago (2016-07-01 16:59:36 UTC) #4
hal.canary
PTAL
4 years, 5 months ago (2016-07-01 17:00:28 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-01 17:15:21 UTC) #8
tomhudson
lgtm
4 years, 5 months ago (2016-07-07 18:50:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119883002/1
4 years, 5 months ago (2016-07-07 19:07:15 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 19:28:34 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/492d6b5b06ce586a19e779ad7867e8f2e9d254b1

Powered by Google App Engine
This is Rietveld 408576698