Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 2119863003: Revert of DevTools: protocol setting files properly handles mimetypes and directories. (Closed)

Created:
4 years, 5 months ago by einbinder
Modified:
4 years, 5 months ago
Reviewers:
tkent, dgozman, lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-html_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: protocol setting files properly handles mimetypes and directories. (patchset #4 id:60001 of https://codereview.chromium.org/2098703003/ ) Reason for revert: Failed https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/38159 Original issue's description: > DevTools: protocol setting files properly handles mimetypes and directories. > > BUG=620367 > > Committed: https://crrev.com/7377ed7748106955dadd95ab254ddd86ae411c16 > Cr-Commit-Position: refs/heads/master@{#403524} TBR=tkent@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=620367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -73 lines) Patch
M third_party/WebKit/Source/core/html/HTMLInputElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputType.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputType.cpp View 2 chunks +12 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputTypeTest.cpp View 2 chunks +0 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
einbinder
Created Revert of DevTools: protocol setting files properly handles mimetypes and directories.
4 years, 5 months ago (2016-07-01 22:19:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119863003/1
4 years, 5 months ago (2016-07-01 22:19:58 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-01 22:20:00 UTC) #5
lushnikov
4 years, 5 months ago (2016-07-01 22:22:09 UTC) #7
rs lgtm

Powered by Google App Engine
This is Rietveld 408576698