Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: build/config/mac/base_rules.gni

Issue 2119843004: WIP // DO NOT SUBMIT Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/mac/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/base_rules.gni
diff --git a/build/config/mac/base_rules.gni b/build/config/mac/base_rules.gni
index 109710dd3f77c4456cdac93bb7b49bf03dd76e96..9b0f368979aafda6028d7a727a7788c9c1be3639 100644
--- a/build/config/mac/base_rules.gni
+++ b/build/config/mac/base_rules.gni
@@ -145,6 +145,11 @@ template("info_plist") {
# structure will not be created, and build output will go directly
# into the framework subdirectory.
#
+# linker_inputs:
+# (optional) list of string, additional inputs to list to the link step
+# that are not source files. Examples would be strip, save, or order
+# files.
+#
# This template provides two targets for the resulting framework bundle. The
# link-time behavior varies depending on which of the two targets below is
# added as a dependency:
@@ -234,6 +239,9 @@ template("framework_bundle") {
_shared_library_target = target_name + "_shared_library"
_shared_library_bundle_data = _shared_library_target + "_bundle_data"
+ # Hack for https://crbug.com/395883.
+ if (defined(invoker.linker_inputs)) { assert(invoker.linker_inputs != []) }
+
shared_library(_shared_library_target) {
visibility = [ ":$_shared_library_bundle_data" ]
forward_variables_from(invoker,
@@ -249,6 +257,9 @@ template("framework_bundle") {
output_prefix_override = true
output_extension = ""
output_dir = "$target_out_dir/$_shared_library_target"
+ if (defined(invoker.linker_inputs)) {
+ inputs = invoker.linker_inputs
+ }
}
bundle_data(_shared_library_bundle_data) {
« no previous file with comments | « no previous file | build/config/mac/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698