Cache hashCode in Uri implementations to improve performance when used as, e.g., Map key.

Cache hashCode in Uri implementations to improve performance when used as, e.g., Map key.

Most URI strings are short, but this still gives a 10%-20% improvement on doing repeated lookup in a large map of URIs in the VM, ~100% speedup in dart2js.

Addresses feature request #18162
BUG= http://dartbug.com/18162
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/a11ad27723b49939307c69d185d7ad5d783d4f5a

[Lasse Reichstein Nielsen, 2016-07-01 10:36:37]

lrn@google.com changed reviewers:
+ floitsch@google.com

[Lasse Reichstein Nielsen, 2016-07-01 12:04:50]

Description was changed from

==========
Cache hashCode in Uri implementations to improve performance when used as, e.g.,
Map key.

Most URI strings are short, but this still gives a 10%-20% improvement on doing
repeated lookup in a large map of URIs.

Addresses feature request #18162
BUG= http://dartbugs.com/18162
==========

to

==========
Cache hashCode in Uri implementations to improve performance when used as, e.g.,
Map key.

Most URI strings are short, but this still gives a 10%-20% improvement on doing
repeated lookup in a large map of URIs in the VM, ~100% speedup in dart2js.

Addresses feature request #18162
BUG= http://dartbugs.com/18162
==========

[floitsch, 2016-07-01 18:19:58]

Description was changed from

==========
Cache hashCode in Uri implementations to improve performance when used as, e.g.,
Map key.

Most URI strings are short, but this still gives a 10%-20% improvement on doing
repeated lookup in a large map of URIs in the VM, ~100% speedup in dart2js.

Addresses feature request #18162
BUG= http://dartbugs.com/18162
==========

to

==========
Cache hashCode in Uri implementations to improve performance when used as, e.g.,
Map key.

Most URI strings are short, but this still gives a 10%-20% improvement on doing
repeated lookup in a large map of URIs in the VM, ~100% speedup in dart2js.

Addresses feature request #18162
BUG= http://dartbug.com/18162
==========

[floitsch, 2016-07-01 18:20:24]

LGTM.

[Lasse Reichstein Nielsen, 2016-07-04 08:19:44]

Description was changed from

==========
Cache hashCode in Uri implementations to improve performance when used as, e.g.,
Map key.

Most URI strings are short, but this still gives a 10%-20% improvement on doing
repeated lookup in a large map of URIs in the VM, ~100% speedup in dart2js.

Addresses feature request #18162
BUG= http://dartbug.com/18162
==========

to

==========
Cache hashCode in Uri implementations to improve performance when used as, e.g.,
Map key.

Most URI strings are short, but this still gives a 10%-20% improvement on doing
repeated lookup in a large map of URIs in the VM, ~100% speedup in dart2js.

Addresses feature request #18162
BUG= http://dartbug.com/18162
R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a11ad27723b49939307c69d185d7ad5d783d4f5a
==========

[Lasse Reichstein Nielsen, 2016-07-04 08:19:46]

Committed patchset #1 (id:1) manually as
a11ad27723b49939307c69d185d7ad5d783d4f5a (presubmit successful).