chrome/browser/captive_portal/captive_portal_detector.h - Issue 211983002: Add logging for distinguishing between captive portals with HTTP and HTTPS login pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/captive_portal/captive_portal_detector.h

Issue 211983002: Add logging for distinguishing between captive portals with HTTP and HTTPS login pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Record the landing url for captive portal probe instead of just the https status Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/captive_portal/captive_portal_detector.h

diff --git a/chrome/browser/captive_portal/captive_portal_detector.h b/chrome/browser/captive_portal/captive_portal_detector.h

index 162ae6e150b55197f70ab5477425518c8163d676..aa72294d621d6a3798740f2ca6b2d7f28a36cc65 100644

--- a/chrome/browser/captive_portal/captive_portal_detector.h

+++ b/chrome/browser/captive_portal/captive_portal_detector.h

@@ -44,6 +44,7 @@ class CaptivePortalDetector : public net::URLFetcherDelegate,

Result result;

int response_code;

base::TimeDelta retry_after_delta;

+ GURL landing_url;

};

typedef base::Callback<void(const Results& results)> DetectionCallback;

« no previous file with comments | « no previous file | chrome/browser/captive_portal/captive_portal_detector.cc » ('j') | chrome/browser/captive_portal/captive_portal_service.cc » ('J')