tools/metrics/histograms/histograms.xml - Issue 211983002: Add logging for distinguishing between captive portals with HTTP and HTTPS login pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 211983002: Add logging for distinguishing between captive portals with HTTP and HTTPS login pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Record the landing url for captive portal probe instead of just the https status Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 7257711da28fa082263ae9b6e2c44ac1424e0ba2..ebf8b290b43ed7dc97e6666725044aef9d15c6e4 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -1751,6 +1751,11 @@ other types of suffix sets.

</summary>

</histogram>

+<histogram name="CaptivePortal.DetectResult" enum="CaptivePortalDetectResult">

+ <owner>mmenke@chromium.org</owner>

mmenke 2014/03/26 17:23:21 Should I really be the owner of this? If we were

meacer 2014/03/26 17:59:32 Sure, I can be the owner. I added you since I thou

+ <summary>Records the result of a captive portal probe.</summary>

+</histogram>

<histogram name="CaptivePortal.Notification.Status"

enum="CaptivePortalNotificationStatus">

<owner>ygorshenin@chromium.org</owner>

@@ -29790,6 +29795,24 @@ other types of suffix sets.

</enum>

+<enum name="CaptivePortalDetectResult" type="int">

+ <int value="0" label="RESULT_INTERNET_CONNECTED">

+ There's a confirmed connection to the Internet.

+ </int>

+ <int value="1" label="RESULT_NO_RESPONSE">

+ Received a network or HTTP error, or a non-HTTP response.

+ </int>

+ <int value="2" label="RESULT_BEHIND_CAPTIVE_PORTAL">

+ Encountered a captive portal with an HTTP login page.

+ </int>

+ <int value="3" label="RESULT_NO_RESPONSE_HTTPS">

+ Received a network or HTTP error with an HTTPS login URL.

+ </int>

+ <int value="4" label="RESULT_BEHIND_CAPTIVE_PORTAL_HTTPS">

+ Encountered a captive portal with an HTTPS login page.

+ </int>

+</enum>

« chrome/browser/captive_portal/captive_portal_service.cc ('K') | « chrome/browser/captive_portal/captive_portal_service.cc ('k') | no next file » | no next file with comments »