Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2119823002: Remove obsolete patching step from runtime callstats.html (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove obsolete patching step from runtime callstats.html BUG= R=cbruni@chromium.org Committed: https://crrev.com/9d66b3f3d3a0135ca8e324e2f24f3a1d9cb70d43 Cr-Commit-Position: refs/heads/master@{#37534}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Total comments: 2

Patch Set 5 : updates #

Patch Set 6 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M tools/callstats.html View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M tools/callstats.py View 1 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (2 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-07-01 09:28:33 UTC) #1
Camillo Bruni
sorry... forgot to press the "send" button this morning. https://codereview.chromium.org/2119823002/diff/60001/tools/callstats.py File tools/callstats.py (right): https://codereview.chromium.org/2119823002/diff/60001/tools/callstats.py#newcode322 tools/callstats.py:322: ...
4 years, 5 months ago (2016-07-05 13:55:23 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2119823002/diff/60001/tools/callstats.py File tools/callstats.py (right): https://codereview.chromium.org/2119823002/diff/60001/tools/callstats.py#newcode322 tools/callstats.py:322: ('Group-Callback', re.compile("Callback$")), On 2016/07/05 at 13:55:23, Camillo Bruni wrote: ...
4 years, 5 months ago (2016-07-05 14:09:39 UTC) #3
jochen (gone - plz use gerrit)
ptal
4 years, 5 months ago (2016-07-05 14:24:27 UTC) #4
Camillo Bruni
On 2016/07/05 at 14:09:39, jochen wrote: > https://codereview.chromium.org/2119823002/diff/60001/tools/callstats.py > File tools/callstats.py (right): > > https://codereview.chromium.org/2119823002/diff/60001/tools/callstats.py#newcode322 ...
4 years, 5 months ago (2016-07-05 14:25:02 UTC) #5
Camillo Bruni
lgtm
4 years, 5 months ago (2016-07-05 14:30:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119823002/100001
4 years, 5 months ago (2016-07-05 14:34:13 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-07-05 14:58:35 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 14:58:37 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 14:59:18 UTC) #12
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/9d66b3f3d3a0135ca8e324e2f24f3a1d9cb70d43
Cr-Commit-Position: refs/heads/master@{#37534}

Powered by Google App Engine
This is Rietveld 408576698