views::Textfield: Implement yank editing command.

ui/views/views_delegate.h

Index: ui/views/views_delegate.h
diff --git a/ui/views/views_delegate.h b/ui/views/views_delegate.h
index 54b5c4383e8d39aaf32dfdc58856ff712925a194..11e45e82ba5ebf9970f611b3ba185e04b8725677 100644
--- a/ui/views/views_delegate.h
+++ b/ui/views/views_delegate.h
@@ -102,6 +102,14 @@ class VIEWS_EXPORT ViewsDelegate {
     return native_widget_factory_;
   }
 
+  const base::string16& kill_buffer() {

[tapted, 2016/07/20 06:32:21]

nit: declare method const

[karandeepb, 2016/07/20 07:51:30]

Done.

+    return kill_buffer_;
+  }
+
+  void set_kill_buffer(const base::string16& kill_buffer) {

[tapted, 2016/07/20 06:32:21]

nit: swap these around and remove the blank line between to be consistent with
native_widget_factory. It should have a brief comment too, like "Access the text
buffer used to implement the "Yank" text edit command."

[karandeepb, 2016/07/20 07:51:30]

Done.

+    kill_buffer_ = kill_buffer;
+  }
+
   // Saves the position, size and "show" state for the window with the
   // specified name.
   virtual void SaveWindowPlacement(const Widget* widget,
@@ -205,6 +213,14 @@ class VIEWS_EXPORT ViewsDelegate {
 
   NativeWidgetFactory native_widget_factory_;
 
+  // Buffer containing the text to be inserted on executing yank command for
+  // Views::Texfield. Member of ViewsDelegate since this needs to be persisted

[tapted, 2016/07/20 06:32:21]

nit: Views -> views

[karandeepb, 2016/07/20 07:51:30]

Done.

+  // across multiple textfield instances.
+  // On Mac, the size of the kill ring (no. of buffers) is controlled by
+  // NSTextKillRingSize, a text system default. However to keep things simple,
+  // the default kill ring size of 1 (i.e. a single buffer) is assumed.
+  base::string16 kill_buffer_;
+
   DISALLOW_COPY_AND_ASSIGN(ViewsDelegate);
 };