Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/x87/assembler-x87.cc

Issue 2119793002: X87: [ia32] Fixes a bug in cmpw. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/x87/disasm-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 703 matching lines...) Expand 10 before | Expand all | Expand 10 after
714 EnsureSpace ensure_space(this); 714 EnsureSpace ensure_space(this);
715 EMIT(0x66); 715 EMIT(0x66);
716 EMIT(0x81); 716 EMIT(0x81);
717 emit_operand(edi, op); 717 emit_operand(edi, op);
718 emit_w(imm16); 718 emit_w(imm16);
719 } 719 }
720 720
721 void Assembler::cmpw(Register reg, const Operand& op) { 721 void Assembler::cmpw(Register reg, const Operand& op) {
722 EnsureSpace ensure_space(this); 722 EnsureSpace ensure_space(this);
723 EMIT(0x66); 723 EMIT(0x66);
724 EMIT(0x3B);
725 emit_operand(reg, op);
726 }
727
728 void Assembler::cmpw(const Operand& op, Register reg) {
729 EnsureSpace ensure_space(this);
730 EMIT(0x66);
724 EMIT(0x39); 731 EMIT(0x39);
725 emit_operand(reg, op); 732 emit_operand(reg, op);
726 } 733 }
727 734
728 void Assembler::cmpw(const Operand& op, Register reg) {
729 EnsureSpace ensure_space(this);
730 EMIT(0x66);
731 EMIT(0x3B);
732 emit_operand(reg, op);
733 }
734
735 void Assembler::cmp(Register reg, int32_t imm32) { 735 void Assembler::cmp(Register reg, int32_t imm32) {
736 EnsureSpace ensure_space(this); 736 EnsureSpace ensure_space(this);
737 emit_arith(7, Operand(reg), Immediate(imm32)); 737 emit_arith(7, Operand(reg), Immediate(imm32));
738 } 738 }
739 739
740 740
741 void Assembler::cmp(Register reg, Handle<Object> handle) { 741 void Assembler::cmp(Register reg, Handle<Object> handle) {
742 EnsureSpace ensure_space(this); 742 EnsureSpace ensure_space(this);
743 emit_arith(7, Operand(reg), Immediate(handle)); 743 emit_arith(7, Operand(reg), Immediate(handle));
744 } 744 }
(...skipping 1486 matching lines...) Expand 10 before | Expand all | Expand 10 after
2231 fflush(coverage_log); 2231 fflush(coverage_log);
2232 } 2232 }
2233 } 2233 }
2234 2234
2235 #endif 2235 #endif
2236 2236
2237 } // namespace internal 2237 } // namespace internal
2238 } // namespace v8 2238 } // namespace v8
2239 2239
2240 #endif // V8_TARGET_ARCH_X87 2240 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « no previous file | src/x87/disasm-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698