runtime/observatory/lib/elements.dart - Issue 2119733003: Wrapping leaf nodes in non polymer elements

Unified Diff: runtime/observatory/lib/elements.dart

Issue 2119733003: Wrapping leaf nodes in non polymer elements (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fixed CSS leak on firefox Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/observatory/lib/elements.dart

diff --git a/runtime/observatory/lib/elements.dart b/runtime/observatory/lib/elements.dart

index 9ee5cf21e3a6c7df91760dcc12e43ca57aed0ff8..2d3a4b1b19b616037bb00a82239e5ffb37b3d589 100644

--- a/runtime/observatory/lib/elements.dart

+++ b/runtime/observatory/lib/elements.dart

@@ -10,7 +10,6 @@ export 'package:observatory/src/elements/code_view.dart';

export 'package:observatory/src/elements/context_ref.dart';

export 'package:observatory/src/elements/context_view.dart';

export 'package:observatory/src/elements/cpu_profile.dart';

-export 'package:observatory/src/elements/curly_block.dart';

export 'package:observatory/src/elements/debugger.dart';

export 'package:observatory/src/elements/error_view.dart';

export 'package:observatory/src/elements/eval_box.dart';

@@ -30,7 +29,6 @@ export 'package:observatory/src/elements/instance_view.dart';

export 'package:observatory/src/elements/instructions_view.dart';

export 'package:observatory/src/elements/io_view.dart';

export 'package:observatory/src/elements/isolate_reconnect.dart';

-export 'package:observatory/src/elements/isolate_ref.dart';

export 'package:observatory/src/elements/isolate_summary.dart';

export 'package:observatory/src/elements/isolate_view.dart';

export 'package:observatory/src/elements/json_view.dart';

@@ -55,7 +53,35 @@ export 'package:observatory/src/elements/service_ref.dart';

export 'package:observatory/src/elements/service_view.dart';

export 'package:observatory/src/elements/sliding_checkbox.dart';

export 'package:observatory/src/elements/timeline_page.dart';

-export 'package:observatory/src/elements/view_footer.dart';

export 'package:observatory/src/elements/vm_connect.dart';

export 'package:observatory/src/elements/vm_ref.dart';

export 'package:observatory/src/elements/vm_view.dart';

+import 'dart:async';

+import 'package:observatory/src/elements/curly_block.dart';

+export 'package:observatory/src/elements/curly_block.dart';

Cutch 2016/07/07 19:50:57 Can we group the import and export lines?

cbernaschina 2016/07/07 22:08:13 Done.

+import 'package:observatory/src/elements/curly_block_wrapper.dart';

+export 'package:observatory/src/elements/curly_block_wrapper.dart';

+import 'package:observatory/src/elements/isolate_ref.dart';

+export 'package:observatory/src/elements/isolate_ref.dart';

+import 'package:observatory/src/elements/isolate_ref_wrapper.dart';

+export 'package:observatory/src/elements/isolate_ref_wrapper.dart';

+import 'package:observatory/src/elements/view_footer.dart';

+export 'package:observatory/src/elements/view_footer.dart';

+// There is no view_footer_wrapper.dart because no binding it needed.

+import 'package:observatory/src/elements/vm_connect_target.dart';

+export 'package:observatory/src/elements/vm_connect_target.dart';

+import 'package:observatory/src/elements/vm_connect_target_wrapper.dart';

+export 'package:observatory/src/elements/vm_connect_target_wrapper.dart';

+Future initElements() async {

Cutch 2016/07/07 19:50:57 Why is this function marked async? Is anything ins

cbernaschina 2016/07/07 22:08:13 Even though this function does not invoke any asyn

+ CurlyBlockElement.tag.ensureRegistration();

+ CurlyBlockElementWrapper.tag.ensureRegistration();

+ IsolateRefElement.tag.ensureRegistration();

+ IsolateRefElementWrapper.tag.ensureRegistration();

+ ViewFooterElement.tag.ensureRegistration();

+ // There is no ViewFooterElementWrapper because no binding it needed.

+ VmConnectTargetElement.tag.ensureRegistration();

+ VmConnectTargetElementWrapper.tag.ensureRegistration();

« no previous file with comments | « no previous file | runtime/observatory/lib/elements.html » ('j') | runtime/observatory/lib/repositories.dart » ('J')