runtime/observatory/lib/src/elements/heap_snapshot.dart - Issue 2119733003: Wrapping leaf nodes in non polymer elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/heap_snapshot.dart

Issue 2119733003: Wrapping leaf nodes in non polymer elements (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Converted vm-connect Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/elements/heap_snapshot.dart

diff --git a/runtime/observatory/lib/src/elements/heap_snapshot.dart b/runtime/observatory/lib/src/elements/heap_snapshot.dart

index 4894e9fcb8d83bf9b6b82071599fe0a75dc3ee3e..8afe7e36df0568be6a235476922a524aaa6237b8 100644

--- a/runtime/observatory/lib/src/elements/heap_snapshot.dart

+++ b/runtime/observatory/lib/src/elements/heap_snapshot.dart

@@ -75,7 +75,7 @@ class DominatorTreeRow extends TableTreeRow {

gap.style.display = 'inline-block';

firstColumn.children.add(gap);

- AnyServiceRefElement objectRef = new Element.tag("any-service-ref");

+ AnyServiceRefElementWrapper objectRef = new Element.tag("any-service-ref");

snapshot.isolate.getObjectByAddress(vertex.address).then((obj) {

objectRef.ref = obj;

});