Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: runtime/observatory/lib/src/elements/error_ref.dart

Issue 2119733003: Wrapping leaf nodes in non polymer elements (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Converted script-link Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/error_ref.dart
diff --git a/runtime/observatory/lib/src/elements/error_ref.dart b/runtime/observatory/lib/src/elements/error_ref.dart
index d69726bdbb791d45a690d11fe1a349f9a9984e6c..f467d24daec1eb4f01c27e9d24b0830f21b1d84a 100644
--- a/runtime/observatory/lib/src/elements/error_ref.dart
+++ b/runtime/observatory/lib/src/elements/error_ref.dart
@@ -4,10 +4,51 @@
library error_ref_element;
-import 'package:polymer/polymer.dart';
-import 'service_ref.dart';
+import 'dart:html';
+import 'dart:async';
+import 'package:observatory/models.dart'
+ show ErrorRef;
+import 'package:observatory/src/elements/helpers/tag.dart';
+import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
-@CustomTag('error-ref')
-class ErrorRefElement extends ServiceRefElement {
- ErrorRefElement.created() : super.created();
+class ErrorRefElement extends HtmlElement implements Renderable {
+ static const tag = const Tag<ErrorRefElement>('error-ref-wrapped');
+
+ RenderingScheduler<ErrorRefElement> _r;
+
+ Stream<RenderedEvent<ErrorRefElement>> get onRendered => _r.onRendered;
+
+ ErrorRef _error;
+ ErrorRef get error => _error;
+
+ factory ErrorRefElement(ErrorRef error) {
+ assert(error != null);
+ ErrorRefElement e = document.createElement(tag.name);
+ e._error = error;
+ return e;
+ }
+
+ ErrorRefElement.created() : super.created() {
+ _r = new RenderingScheduler<ErrorRefElement> (this);
+ }
+
+ @override
+ void attached() {
+ super.attached();
+ assert(error != null);
+ _r.scheduleRendering();
+ }
+
+ @override
+ void detached() {
+ super.detached();
+ children = [];
+ _r.scheduleNotification();
+ }
+
+ void render() {
+ children = [
+ new PreElement()..text = error.message
+ ];
+ }
}

Powered by Google App Engine
This is Rietveld 408576698