Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Unified Diff: runtime/observatory/lib/src/elements/isolate_ref.dart

Issue 2119733003: Wrapping leaf nodes in non polymer elements (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/isolate_ref.dart
diff --git a/runtime/observatory/lib/src/elements/isolate_ref.dart b/runtime/observatory/lib/src/elements/isolate_ref.dart
index 730a4383800b11a6be12506e3f2a086943cafa42..aeadc63ca264ddc7a0453b5fa370323b8906ea28 100644
--- a/runtime/observatory/lib/src/elements/isolate_ref.dart
+++ b/runtime/observatory/lib/src/elements/isolate_ref.dart
@@ -4,10 +4,52 @@
library isolate_ref_element;
-import 'package:polymer/polymer.dart';
-import 'service_ref.dart';
+import 'dart:html';
+import 'package:observatory/service_html.dart';
+import 'helpers/tag.dart';
-@CustomTag('isolate-ref')
-class IsolateRefElement extends ServiceRefElement {
- IsolateRefElement.created() : super.created();
+class IsolateRefElement extends HtmlElement {
+ static final StyleElement _style = () {
+ var style = new StyleElement();
+ style.text = 'a {'
+ ' color: #0489c3;'
+ ' text-decoration: none;'
+ '}'
+ 'a:hover {'
+ ' text-decoration: underline;'
+ '}';
+ return style;
+ }();
+
+ static const tag = const Tag<IsolateRefElement>('isolate-ref-wrapped');
+
+ Isolate isolate;
+
+ factory IsolateRefElement({Isolate isolate}) {
+ IsolateRefElement e = document.createElement(tag.name);
+ e.isolate = isolate;
+ return e;
+ }
+
+ IsolateRefElement.created() : super.created() {
+ createShadowRoot();
+ }
+
+ @override
+ void attached() {
+ super.attached();
+ render();
+ }
+
+ void render() {
+ shadowRoot.children = [];
+ if (isolate == null) return;
+
+ shadowRoot.children = [
+ _style.clone(true),
+ new AnchorElement(href:
+ '#/inspect?isolateId=${Uri.encodeComponent(isolate.id)}')
Cutch 2016/07/01 17:33:36 We should probably delegate the href building to s
+ ..text = 'Isolate ${isolate.number} (${isolate.name})'
+ ];
+ }
}
« no previous file with comments | « runtime/observatory/lib/src/elements/instance_view.html ('k') | runtime/observatory/lib/src/elements/isolate_ref.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698