Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1331)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html

Issue 2119713003: Pin keyboard use enter to submit when focus is not on a button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fixed patch set 1 errors. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js » ('j') | chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
diff --git a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
index 3e11127c88f77cb4ae9ebe5bcc67f79b487a93c4..8bfaf46746ef62718b34a90e7dcf445241e140d4 100644
--- a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
+++ b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
@@ -108,6 +108,7 @@
on-keydown="onInputKeyDown_"></input>
<div class="digit-button first-row">
<paper-button class="digit-button submit-button"
+ on-keyup="onButtonKeyUp_"
on-tap="firePinSubmitEvent_">
<div class="icon-container">
<iron-icon class="icon" icon="icons:forward"><iron-icon>
@@ -117,44 +118,56 @@
</div>
<div class="row keyboard">
- <paper-button class="digit-button" on-tap="onNumberTap_" value="1">
+ <paper-button class="digit-button" on-keyup="onButtonKeyUp_"
+ on-tap="onNumberTap_" value="1">
<inner-text>1</inner-text>
</paper-button>
- <paper-button class="digit-button" on-tap="onNumberTap_" value="2">
+ <paper-button class="digit-button" on-keyup="onButtonKeyUp_"
+ on-tap="onNumberTap_" value="2">
<inner-text>2</inner-text>
</paper-button>
- <paper-button class="digit-button" on-tap="onNumberTap_" value="3">
+ <paper-button class="digit-button" on-keyup="onButtonKeyUp_"
+ on-tap="onNumberTap_" value="3">
<inner-text>3</inner-text>
</paper-button>
</div>
<div class="row keyboard">
- <paper-button class="digit-button" on-tap="onNumberTap_" value="4">
+ <paper-button class="digit-button" on-keyup="onButtonKeyUp_"
+ on-tap="onNumberTap_" value="4">
<inner-text>4</inner-text>
</paper-button>
- <paper-button class="digit-button" on-tap="onNumberTap_" value="5">
+ <paper-button class="digit-button" on-keyup="onButtonKeyUp_"
+ on-tap="onNumberTap_" value="5">
<inner-text>5</inner-text>
</paper-button>
- <paper-button class="digit-button" on-tap="onNumberTap_" value="6">
+ <paper-button class="digit-button" on-keyup="onButtonKeyUp_"
+ on-tap="onNumberTap_" value="6">
<inner-text>6</inner-text>
</paper-button>
</div>
<div class="row keyboard">
- <paper-button class="digit-button" on-tap="onNumberTap_" value="7">
+ <paper-button class="digit-button" on-keyup="onButtonKeyUp_"
+ on-tap="onNumberTap_" value="7">
<inner-text>7</inner-text>
</paper-button>
- <paper-button class="digit-button" on-tap="onNumberTap_" value="8">
+ <paper-button class="digit-button" on-keyup="onButtonKeyUp_"
+ on-tap="onNumberTap_" value="8">
<inner-text>8</inner-text>
</paper-button>
- <paper-button class="digit-button" on-tap="onNumberTap_" value="9">
+ <paper-button class="digit-button" on-keyup="onButtonKeyUp_"
+ on-tap="onNumberTap_" value="9">
<inner-text>9</inner-text>
</paper-button>
</div>
<div class="row keyboard">
<div class="digit-button"></div>
- <paper-button class="digit-button" on-tap="onNumberTap_" value="0">
+ <paper-button class="digit-button" on-keyup="onButtonKeyUp_"
+ on-tap="onNumberTap_" value="1">
<inner-text>0</inner-text>
</paper-button>
- <paper-button class="digit-button clear-button" on-tap="onPinClear_">
+ <paper-button class="digit-button clear-button"
+ on-keyup="onButtonKeyUp_"
+ on-tap="onPinClear_">
<div class="icon-container">
<iron-icon class="icon" icon="icons:clear"><iron-icon>
</div>
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js » ('j') | chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698