Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html

Issue 2119713003: Pin keyboard use enter to submit when focus is not on a button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!-- TODO(crbug.com/603217): Use i18n instead of string literals. Figure out 1 <!-- TODO(crbug.com/603217): Use i18n instead of string literals. Figure out
2 what i18n to use for keypad, ie, does 1 ABC make 2 what i18n to use for keypad, ie, does 1 ABC make
3 sense in every scenario? --> 3 sense in every scenario? -->
4 4
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/paper-styl es.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/paper-styl es.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml">
9 9
10 <dom-module id="pin-keyboard"> 10 <dom-module id="pin-keyboard">
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 </style> 101 </style>
102 102
103 <div id="root"> 103 <div id="root">
104 <div id="container-constrained-width"> 104 <div id="container-constrained-width">
105 <div class="row horizontal-center"> 105 <div class="row horizontal-center">
106 <input id="pin-input" type="number" placeholder="Enter PIN" 106 <input id="pin-input" type="number" placeholder="Enter PIN"
107 value="{{value::input}}" 107 value="{{value::input}}"
108 on-keydown="onInputKeyDown_"></input> 108 on-keydown="onInputKeyDown_"></input>
109 <div class="digit-button first-row"> 109 <div class="digit-button first-row">
110 <paper-button class="digit-button submit-button" 110 <paper-button class="digit-button submit-button"
111 on-focus="onButtonFocus_"
jdufault 2016/06/30 22:18:44 Can we use one of the paper-button properties inst
sammiequon 2016/07/01 21:13:58 Done.
112 on-keydown="onButtonKeyDown_"
111 on-tap="firePinSubmitEvent_"> 113 on-tap="firePinSubmitEvent_">
112 <div class="icon-container"> 114 <div class="icon-container">
113 <iron-icon class="icon" icon="icons:forward"><iron-icon> 115 <iron-icon class="icon" icon="icons:forward"><iron-icon>
114 </div> 116 </div>
115 </paper-button> 117 </paper-button>
116 </div> 118 </div>
117 </div> 119 </div>
118 120
119 <div class="row keyboard"> 121 <div class="row keyboard">
120 <paper-button class="digit-button" on-tap="onNumberTap_" value="1"> 122 <paper-button class="digit-button" on-focus="onButtonFocus_"
123 on-keydown="onButtonKeyDown_"
124 on-tap="onNumberTap_" value="1">
121 <inner-text>1</inner-text> 125 <inner-text>1</inner-text>
122 </paper-button> 126 </paper-button>
123 <paper-button class="digit-button" on-tap="onNumberTap_" value="2"> 127 <paper-button class="digit-button" on-focus="onButtonFocus_"
128 on-keydown="onButtonKeyDown_"
129 on-tap="onNumberTap_" value="1">
124 <inner-text>2</inner-text> 130 <inner-text>2</inner-text>
125 </paper-button> 131 </paper-button>
126 <paper-button class="digit-button" on-tap="onNumberTap_" value="3"> 132 <paper-button class="digit-button" on-focus="onButtonFocus_"
133 on-keydown="onButtonKeyDown_"
134 on-tap="onNumberTap_" value="1">
127 <inner-text>3</inner-text> 135 <inner-text>3</inner-text>
128 </paper-button> 136 </paper-button>
129 </div> 137 </div>
130 <div class="row keyboard"> 138 <div class="row keyboard">
131 <paper-button class="digit-button" on-tap="onNumberTap_" value="4"> 139 <paper-button class="digit-button" on-focus="onButtonFocus_"
140 on-keydown="onButtonKeyDown_"
141 on-tap="onNumberTap_" value="1">
132 <inner-text>4</inner-text> 142 <inner-text>4</inner-text>
133 </paper-button> 143 </paper-button>
134 <paper-button class="digit-button" on-tap="onNumberTap_" value="5"> 144 <paper-button class="digit-button" on-focus="onButtonFocus_"
145 on-keydown="onButtonKeyDown_"
146 on-tap="onNumberTap_" value="1">
135 <inner-text>5</inner-text> 147 <inner-text>5</inner-text>
136 </paper-button> 148 </paper-button>
137 <paper-button class="digit-button" on-tap="onNumberTap_" value="6"> 149 <paper-button class="digit-button" on-focus="onButtonFocus_"
150 on-keydown="onButtonKeyDown_"
151 on-tap="onNumberTap_" value="1">
138 <inner-text>6</inner-text> 152 <inner-text>6</inner-text>
139 </paper-button> 153 </paper-button>
140 </div> 154 </div>
141 <div class="row keyboard"> 155 <div class="row keyboard">
142 <paper-button class="digit-button" on-tap="onNumberTap_" value="7"> 156 <paper-button class="digit-button" on-focus="onButtonFocus_"
157 on-keydown="onButtonKeyDown_"
158 on-tap="onNumberTap_" value="1">
143 <inner-text>7</inner-text> 159 <inner-text>7</inner-text>
144 </paper-button> 160 </paper-button>
145 <paper-button class="digit-button" on-tap="onNumberTap_" value="8"> 161 <paper-button class="digit-button" on-focus="onButtonFocus_"
162 on-keydown="onButtonKeyDown_"
163 on-tap="onNumberTap_" value="1">
146 <inner-text>8</inner-text> 164 <inner-text>8</inner-text>
147 </paper-button> 165 </paper-button>
148 <paper-button class="digit-button" on-tap="onNumberTap_" value="9"> 166 <paper-button class="digit-button" on-focus="onButtonFocus_"
167 on-keydown="onButtonKeyDown_"
168 on-tap="onNumberTap_" value="1">
149 <inner-text>9</inner-text> 169 <inner-text>9</inner-text>
150 </paper-button> 170 </paper-button>
151 </div> 171 </div>
152 <div class="row keyboard"> 172 <div class="row keyboard">
153 <div class="digit-button"></div> 173 <div class="digit-button"></div>
154 <paper-button class="digit-button" on-tap="onNumberTap_" value="0"> 174 <paper-button class="digit-button" on-focus="onButtonFocus_"
175 on-keydown="onButtonKeyDown_"
176 on-tap="onNumberTap_" value="1">
155 <inner-text>0</inner-text> 177 <inner-text>0</inner-text>
156 </paper-button> 178 </paper-button>
157 <paper-button class="digit-button clear-button" on-tap="onPinClear_"> 179 <paper-button class="digit-button clear-button"
180 on-focus="onButtonFocus_"
181 on-keydown="onButtonKeyDown_"
182 on-tap="onPinClear_">
158 <div class="icon-container"> 183 <div class="icon-container">
159 <iron-icon class="icon" icon="icons:clear"><iron-icon> 184 <iron-icon class="icon" icon="icons:clear"><iron-icon>
160 </div> 185 </div>
161 <inner-text class="icon-subheading">Clear</inner-text> 186 <inner-text class="icon-subheading">Clear</inner-text>
162 </paper-button> 187 </paper-button>
163 </div> 188 </div>
164 </div> 189 </div>
165 </div> 190 </div>
166 </template> 191 </template>
167 <script src="pin_keyboard.js"></script> 192 <script src="pin_keyboard.js"></script>
168 </dom-module> 193 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698