Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2119683002: Move TestExtraData classes to anonymous namespace. (Closed)

Created:
4 years, 5 months ago by pcc1
Modified:
4 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, blink-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move TestExtraData classes to anonymous namespace. We were previously declaring two different classes with the name blink::TestExtraData, which is an ODR violation. As it happens, their implementations compiled to the same machine code, which allowed the tests to pass in most normal circumstances. However, the ODR violation causes test failures in CFI mode (e.g. [1]) as a result of stricter type checking. The fix is to move both classes to an anonymous namespace which makes them internal to their TUs. [1] https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/5924/steps/webkit_unit_tests/logs/WebURLResponseTest.ExtraData BUG=464797 R=thakis@chromium.org Committed: https://crrev.com/2a76d152793a2d3a7d89f26912d2af2ca31a2335 Cr-Commit-Position: refs/heads/master@{#403338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/web/tests/WebURLRequestTest.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebURLResponseTest.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pcc1
4 years, 5 months ago (2016-06-30 21:20:22 UTC) #1
Nico
lgtm
4 years, 5 months ago (2016-06-30 22:15:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119683002/1
4 years, 5 months ago (2016-06-30 22:17:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 23:34:18 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 23:34:20 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 23:37:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a76d152793a2d3a7d89f26912d2af2ca31a2335
Cr-Commit-Position: refs/heads/master@{#403338}

Powered by Google App Engine
This is Rietveld 408576698