Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 2119673002: Precache manifest should not be added to fetcher pool which is full (Closed)

Created:
4 years, 5 months ago by tbansal1
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, wifiprefetch-reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Precache manifest should not be added to fetcher pool which is full Fetcher pool accepts limited number of requests which are fetched in parallel. If the pool is full, precache manifest resources should not be added to it. BUG=606231 Review-Url: https://codereview.chromium.org/2037903002 Cr-Commit-Position: refs/heads/master@{#399387} (cherry picked from commit b2754f713e984d267353ce00d8a9e5ff6a6fafae) Committed: https://chromium.googlesource.com/chromium/src/+/ad72f670be610f05a71251b012dd47d9e32c53a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -6 lines) Patch
M components/precache/core/fetcher_pool.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/precache/core/precache_fetcher.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/precache/core/precache_fetcher.cc View 1 chunk +1 line, -4 lines 0 comments Download
M components/precache/core/precache_fetcher_unittest.cc View 5 chunks +95 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
tbansal1
Committed patchset #1 (id:1) manually as ad72f670be610f05a71251b012dd47d9e32c53a5.
4 years, 5 months ago (2016-06-30 20:48:52 UTC) #2
tbansal1
4 years, 5 months ago (2016-06-30 21:39:21 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2111293002/ by tbansal@chromium.org.

The reason for reverting is: Broke the official.desktop.continuous

https://bugs.chromium.org/p/chromium/issues/detail?id=624936.

Powered by Google App Engine
This is Rietveld 408576698