Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2119643002: Attempted to fix crash in BrowserAccessibilityWin::RemoveBidirectionalRelation. (Closed)

Created:
4 years, 5 months ago by nektarios
Modified:
4 years, 5 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempted to fix crash in BrowserAccessibilityWin::RemoveBidirectionalRelation. BUG=624626 R=dmazzoni@chromium.org Committed: https://crrev.com/02970ff8bb63db38e86cceb455a298d4d1eb5162 Cr-Commit-Position: refs/heads/master@{#403323}

Patch Set 1 #

Patch Set 2 : Removed reflexive relations. #

Total comments: 1

Patch Set 3 : Changed attributes to target_ids. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 6 chunks +20 lines, -5 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
nektarios
4 years, 5 months ago (2016-06-30 20:03:16 UTC) #1
dmazzoni
lgtm https://codereview.chromium.org/2119643002/diff/20001/content/browser/accessibility/browser_accessibility_win.cc File content/browser/accessibility/browser_accessibility_win.cc (right): https://codereview.chromium.org/2119643002/diff/20001/content/browser/accessibility/browser_accessibility_win.cc#newcode4477 content/browser/accessibility/browser_accessibility_win.cc:4477: const std::vector<int32_t>& attributes = GetIntListAttribute(attribute); How about "target_ids" ...
4 years, 5 months ago (2016-06-30 21:13:29 UTC) #2
chromium-reviews
How about "target_ids" and "filtered_target_ids" instead of "attributes" > and "filtered_attributes". Done. -- You received ...
4 years, 5 months ago (2016-06-30 21:58:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119643002/40001
4 years, 5 months ago (2016-06-30 22:00:03 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 23:05:56 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 23:06:09 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 23:09:20 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/02970ff8bb63db38e86cceb455a298d4d1eb5162
Cr-Commit-Position: refs/heads/master@{#403323}

Powered by Google App Engine
This is Rietveld 408576698