runtime/vm/intrinsifier_arm.cc - Issue 2119633002: Remove support for pretenuring as it is not fully implemented and is currently turned on for a very…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_arm.cc

Issue 2119633002: Remove support for pretenuring as it is not fully implemented and is currently turned on for a very… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address self review changes. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intrinsifier_arm.cc

diff --git a/runtime/vm/intrinsifier_arm.cc b/runtime/vm/intrinsifier_arm.cc

index e17abcb149f0de61c9058a3553ae74905f279b51..136e275b60ac0caeba58b2fd3c314410d8768d92 100644

--- a/runtime/vm/intrinsifier_arm.cc

+++ b/runtime/vm/intrinsifier_arm.cc

@@ -183,7 +183,7 @@ void Intrinsifier::GrowableArray_add(Assembler* assembler) {

const intptr_t fixed_size = sizeof(Raw##type_name) + kObjectAlignment - 1; \

__ AddImmediate(R2, fixed_size); \

__ bic(R2, R2, Operand(kObjectAlignment - 1)); \

- Heap::Space space = Heap::SpaceForAllocation(cid); \

+ Heap::Space space = Heap::kNew; \

__ ldr(R3, Address(THR, Thread::heap_offset())); \

__ ldr(R0, Address(R3, Heap::TopOffset(space))); \

@@ -1833,7 +1833,7 @@ static void TryAllocateOnebyteString(Assembler* assembler,

__ bic(length_reg, length_reg, Operand(kObjectAlignment - 1));

const intptr_t cid = kOneByteStringCid;

- Heap::Space space = Heap::SpaceForAllocation(cid);

+ Heap::Space space = Heap::kNew;

__ ldr(R3, Address(THR, Thread::heap_offset()));

__ ldr(R0, Address(R3, Heap::TopOffset(space)));

« no previous file with comments | « runtime/vm/heap.cc ('k') | runtime/vm/intrinsifier_arm64.cc » ('j') | no next file with comments »