Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: runtime/lib/string.cc

Issue 2119633002: Remove support for pretenuring as it is not fully implemented and is currently turned on for a very… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address self review changes. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/double.cc ('k') | runtime/vm/assembler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/string.cc
diff --git a/runtime/lib/string.cc b/runtime/lib/string.cc
index 01f6ad026771b758362cfc8f37e062f16a2c54c3..d4008a36e8ad5d4c0e5495d022a3d89aa096f189 100644
--- a/runtime/lib/string.cc
+++ b/runtime/lib/string.cc
@@ -300,8 +300,7 @@ DEFINE_NATIVE_ENTRY(OneByteString_splitWithCharCode, 2) {
DEFINE_NATIVE_ENTRY(OneByteString_allocate, 1) {
GET_NON_NULL_NATIVE_ARGUMENT(Smi, length_obj, arguments->NativeArgAt(0));
- Heap::Space space = isolate->heap()->SpaceForAllocation(kOneByteStringCid);
- return OneByteString::New(length_obj.Value(), space);
+ return OneByteString::New(length_obj.Value(), Heap::kNew);
}
@@ -326,7 +325,7 @@ DEFINE_NATIVE_ENTRY(OneByteString_allocateFromOneByteList, 3) {
}
ASSERT(length >= 0);
- Heap::Space space = isolate->heap()->SpaceForAllocation(kOneByteStringCid);
+ Heap::Space space = Heap::kNew;
if (list.IsTypedData()) {
const TypedData& array = TypedData::Cast(list);
if (end > array.LengthInBytes()) {
@@ -425,7 +424,7 @@ DEFINE_NATIVE_ENTRY(TwoByteString_allocateFromTwoByteList, 3) {
Exceptions::ThrowArgumentError(end_obj);
}
- Heap::Space space = isolate->heap()->SpaceForAllocation(kTwoByteStringCid);
+ Heap::Space space = Heap::kNew;
if (list.IsTypedData()) {
const TypedData& array = TypedData::Cast(list);
if (array.ElementType() != kUint16ArrayElement) {
« no previous file with comments | « runtime/lib/double.cc ('k') | runtime/vm/assembler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698