Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: runtime/vm/assembler_arm.cc

Issue 2119633002: Remove support for pretenuring as it is not fully implemented and is currently turned on for a very… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address self review changes. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/lib/string.cc ('k') | runtime/vm/assembler_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // NOLINT 5 #include "vm/globals.h" // NOLINT
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/cpu.h" 9 #include "vm/cpu.h"
10 #include "vm/longjump.h" 10 #include "vm/longjump.h"
(...skipping 3460 matching lines...) Expand 10 before | Expand all | Expand 10 after
3471 ASSERT(failure != NULL); 3471 ASSERT(failure != NULL);
3472 if (FLAG_inline_alloc) { 3472 if (FLAG_inline_alloc) {
3473 ASSERT(instance_reg != temp_reg); 3473 ASSERT(instance_reg != temp_reg);
3474 ASSERT(temp_reg != IP); 3474 ASSERT(temp_reg != IP);
3475 const intptr_t instance_size = cls.instance_size(); 3475 const intptr_t instance_size = cls.instance_size();
3476 ASSERT(instance_size != 0); 3476 ASSERT(instance_size != 0);
3477 // If this allocation is traced, program will jump to failure path 3477 // If this allocation is traced, program will jump to failure path
3478 // (i.e. the allocation stub) which will allocate the object and trace the 3478 // (i.e. the allocation stub) which will allocate the object and trace the
3479 // allocation call site. 3479 // allocation call site.
3480 MaybeTraceAllocation(cls.id(), temp_reg, failure); 3480 MaybeTraceAllocation(cls.id(), temp_reg, failure);
3481 Heap::Space space = Heap::SpaceForAllocation(cls.id()); 3481 Heap::Space space = Heap::kNew;
3482 ldr(temp_reg, Address(THR, Thread::heap_offset())); 3482 ldr(temp_reg, Address(THR, Thread::heap_offset()));
3483 ldr(instance_reg, Address(temp_reg, Heap::TopOffset(space))); 3483 ldr(instance_reg, Address(temp_reg, Heap::TopOffset(space)));
3484 // TODO(koda): Protect against unsigned overflow here. 3484 // TODO(koda): Protect against unsigned overflow here.
3485 AddImmediateSetFlags(instance_reg, instance_reg, instance_size); 3485 AddImmediateSetFlags(instance_reg, instance_reg, instance_size);
3486 3486
3487 // instance_reg: potential next object start. 3487 // instance_reg: potential next object start.
3488 ldr(IP, Address(temp_reg, Heap::EndOffset(space))); 3488 ldr(IP, Address(temp_reg, Heap::EndOffset(space)));
3489 cmp(IP, Operand(instance_reg)); 3489 cmp(IP, Operand(instance_reg));
3490 // fail if heap end unsigned less than or equal to instance_reg. 3490 // fail if heap end unsigned less than or equal to instance_reg.
3491 b(failure, LS); 3491 b(failure, LS);
(...skipping 26 matching lines...) Expand all
3518 Label* failure, 3518 Label* failure,
3519 Register instance, 3519 Register instance,
3520 Register end_address, 3520 Register end_address,
3521 Register temp1, 3521 Register temp1,
3522 Register temp2) { 3522 Register temp2) {
3523 if (FLAG_inline_alloc) { 3523 if (FLAG_inline_alloc) {
3524 // If this allocation is traced, program will jump to failure path 3524 // If this allocation is traced, program will jump to failure path
3525 // (i.e. the allocation stub) which will allocate the object and trace the 3525 // (i.e. the allocation stub) which will allocate the object and trace the
3526 // allocation call site. 3526 // allocation call site.
3527 MaybeTraceAllocation(cid, temp1, failure); 3527 MaybeTraceAllocation(cid, temp1, failure);
3528 Heap::Space space = Heap::SpaceForAllocation(cid); 3528 Heap::Space space = Heap::kNew;
3529 ldr(temp1, Address(THR, Thread::heap_offset())); 3529 ldr(temp1, Address(THR, Thread::heap_offset()));
3530 // Potential new object start. 3530 // Potential new object start.
3531 ldr(instance, Address(temp1, Heap::TopOffset(space))); 3531 ldr(instance, Address(temp1, Heap::TopOffset(space)));
3532 AddImmediateSetFlags(end_address, instance, instance_size); 3532 AddImmediateSetFlags(end_address, instance, instance_size);
3533 b(failure, CS); // Branch if unsigned overflow. 3533 b(failure, CS); // Branch if unsigned overflow.
3534 3534
3535 // Check if the allocation fits into the remaining space. 3535 // Check if the allocation fits into the remaining space.
3536 // instance: potential new object start. 3536 // instance: potential new object start.
3537 // end_address: potential next object start. 3537 // end_address: potential next object start.
3538 ldr(temp2, Address(temp1, Heap::EndOffset(space))); 3538 ldr(temp2, Address(temp1, Heap::EndOffset(space)));
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
3669 3669
3670 3670
3671 const char* Assembler::FpuRegisterName(FpuRegister reg) { 3671 const char* Assembler::FpuRegisterName(FpuRegister reg) {
3672 ASSERT((0 <= reg) && (reg < kNumberOfFpuRegisters)); 3672 ASSERT((0 <= reg) && (reg < kNumberOfFpuRegisters));
3673 return fpu_reg_names[reg]; 3673 return fpu_reg_names[reg];
3674 } 3674 }
3675 3675
3676 } // namespace dart 3676 } // namespace dart
3677 3677
3678 #endif // defined TARGET_ARCH_ARM 3678 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/lib/string.cc ('k') | runtime/vm/assembler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698