Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2119623003: Do not clear canvas with transparent color after creating SkSurface (Closed)

Created:
4 years, 5 months ago by xidachen
Modified:
4 years, 5 months ago
CC:
chromium-reviews, krit, dshwang, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, pdr+graphicswatchlist_chromium.org, Justin Novosad, jbroman, blink-reviews-platform-graphics_chromium.org, dglazkov+blink, Rik, dcheng, blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not clear canvas with transparent color after creating SkSurface Recently SkSurface::MakeRaster changed its implementation to zero its malloced space. So after creating the SkSurface, there is no need to call sksurface's canvas->clear(SK_ColorTRANSPARENT). This CL removes that step. Committed: https://crrev.com/51c4765d8e7934359e8f5793ad444c02e45a4d28 Cr-Commit-Position: refs/heads/master@{#403907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/DragImage.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImagePattern.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
xidachen
PTAL
4 years, 5 months ago (2016-06-30 20:11:07 UTC) #2
f(malita)
LGTM, but I'd like to get Skia to commit to surface initialization officially. If you ...
4 years, 5 months ago (2016-07-01 12:59:31 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119623003/1
4 years, 5 months ago (2016-07-06 13:33:16 UTC) #6
f(malita)
On 2016/07/01 12:59:31, f(malita) wrote: > LGTM, but I'd like to get Skia to commit ...
4 years, 5 months ago (2016-07-06 14:03:16 UTC) #7
xidachen
Thanks, Florin. junov@: FYI.
4 years, 5 months ago (2016-07-06 14:04:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119623003/1
4 years, 5 months ago (2016-07-06 14:04:50 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 14:50:28 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 14:51:32 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51c4765d8e7934359e8f5793ad444c02e45a4d28
Cr-Commit-Position: refs/heads/master@{#403907}

Powered by Google App Engine
This is Rietveld 408576698