Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: net/http/http_basic_stream.cc

Issue 2119623002: Add metrics to track HTTP/0.9 usage for main frames and subresources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_basic_stream.cc
diff --git a/net/http/http_basic_stream.cc b/net/http/http_basic_stream.cc
index 9ebb5e32d866ee7c31ac007f112050d688cffd19..a82f9fccaf464981a25ce659987e62f673c886fb 100644
--- a/net/http/http_basic_stream.cc
+++ b/net/http/http_basic_stream.cc
@@ -124,7 +124,9 @@ void HttpBasicStream::Drain(HttpNetworkSession* session) {
}
void HttpBasicStream::PopulateNetErrorDetails(NetErrorDetails* details) {
- details->connection_info = HttpResponseInfo::CONNECTION_INFO_HTTP1;
+ // TODO(mmenke): Consumers don't actually care about HTTP version, but seems
+ // like the right version should be reported, if headers were received.
+ details->connection_info = HttpResponseInfo::CONNECTION_INFO_HTTP1_1;
mmenke 2016/06/30 22:18:07 This is really weird, and should be fixed. Unfort
return;
}

Powered by Google App Engine
This is Rietveld 408576698