Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Unified Diff: content/browser/loader/resource_loader.cc

Issue 2119623002: Add metrics to track HTTP/0.9 usage for main frames and subresources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: placate clang Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_response_info.h » ('j') | net/http/http_response_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/resource_loader.cc
diff --git a/content/browser/loader/resource_loader.cc b/content/browser/loader/resource_loader.cc
index 8c05ad21940fde80d31acd1a3a251237c4b9dc9c..3ae7756bbccb62dfe28fc99a938fab81191a3233 100644
--- a/content/browser/loader/resource_loader.cc
+++ b/content/browser/loader/resource_loader.cc
@@ -717,6 +717,16 @@ void ResourceLoader::RecordHistograms() {
ResourceRequestInfoImpl* info = GetRequestInfo();
+ if (info->GetResourceType() == RESOURCE_TYPE_MAIN_FRAME) {
+ UMA_HISTOGRAM_ENUMERATION("Net.HttpResponseInfo.ConnectionInfo.SubResource",
Bence 2016/06/30 21:20:11 I think you got the two branches backwards.
mmenke 2016/06/30 22:18:07 Thanks for catching that! Done.
+ request_->response_info().connection_info,
+ net::HttpResponseInfo::NUM_OF_CONNECTION_INFOS);
+ } else {
+ UMA_HISTOGRAM_ENUMERATION("Net.HttpResponseInfo.ConnectionInfo.MainFrame",
+ request_->response_info().connection_info,
+ net::HttpResponseInfo::NUM_OF_CONNECTION_INFOS);
+ }
+
if (info->GetResourceType() == RESOURCE_TYPE_PREFETCH) {
PrefetchStatus status = STATUS_UNDEFINED;
TimeDelta total_time = base::TimeTicks::Now() - request_->creation_time();
« no previous file with comments | « no previous file | net/http/http_response_info.h » ('j') | net/http/http_response_info.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698