Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2119593002:
Add fatal_linker_warnings flag for GN builds (Closed)
DescriptionAdd fatal_linker_warnings flag to GN builds
Add a flag for disable fatal linker warnings. The
flag corresponds to the GYP fatal_linker_warnings
option. By default fatal linker warnings are enabled.
BUG=
Committed: https://crrev.com/c804b74f6c3af31b74fbf652c38e8d5c61655b91
Cr-Commit-Position: refs/heads/master@{#403252}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 19 (11 generated)
Description was changed from ========== Add fatal_linker_warnings flag for GN builds Add a flag for disable fatal linker warnings. This flag corresponds to the GYP fatal_linker_warnings flag. By default fatal linker warnings are enabled. BUG= Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org> ========== to ========== Add fatal_linker_warnings flag for GN builds Add a flag for disable fatal linker warnings. This flag corresponds to the GYP fatal_linker_warnings flag. By default fatal linker warnings are enabled. BUG= Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org> ==========
zoltan.kuscsik@linaro.org changed reviewers: + dpranke@google.com, thakis@chromium.org
Description was changed from ========== Add fatal_linker_warnings flag for GN builds Add a flag for disable fatal linker warnings. This flag corresponds to the GYP fatal_linker_warnings flag. By default fatal linker warnings are enabled. BUG= Signed-off-by: Zoltan Kuscsik <zoltan.kuscsik@linaro.org> ========== to ========== Add fatal_linker_warnings flag for GN builds Add a flag for disable fatal linker warnings. This flag corresponds to the GYP fatal_linker_warnings flag. By default fatal linker warnings are enabled. BUG= ==========
Description was changed from ========== Add fatal_linker_warnings flag for GN builds Add a flag for disable fatal linker warnings. This flag corresponds to the GYP fatal_linker_warnings flag. By default fatal linker warnings are enabled. BUG= ========== to ========== Add fatal_linker_warnings flag to GN builds Add a flag for disable fatal linker warnings. This flag corresponds to the GYP fatal_linker_warnings flag. By default fatal linker warnings are enabled. BUG= ==========
Description was changed from ========== Add fatal_linker_warnings flag to GN builds Add a flag for disable fatal linker warnings. This flag corresponds to the GYP fatal_linker_warnings flag. By default fatal linker warnings are enabled. BUG= ========== to ========== Add fatal_linker_warnings flag to GN builds Add a flag for disable fatal linker warnings. The flag corresponds to the GYP fatal_linker_warnings option. By default fatal linker warnings are enabled. BUG= ==========
The CQ bit was checked by zoltan.kuscsik@linaro.org
The CQ bit was unchecked by zoltan.kuscsik@linaro.org
lgtm
The CQ bit was checked by zoltan.kuscsik@linaro.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add fatal_linker_warnings flag to GN builds Add a flag for disable fatal linker warnings. The flag corresponds to the GYP fatal_linker_warnings option. By default fatal linker warnings are enabled. BUG= ========== to ========== Add fatal_linker_warnings flag to GN builds Add a flag for disable fatal linker warnings. The flag corresponds to the GYP fatal_linker_warnings option. By default fatal linker warnings are enabled. BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add fatal_linker_warnings flag to GN builds Add a flag for disable fatal linker warnings. The flag corresponds to the GYP fatal_linker_warnings option. By default fatal linker warnings are enabled. BUG= ========== to ========== Add fatal_linker_warnings flag to GN builds Add a flag for disable fatal linker warnings. The flag corresponds to the GYP fatal_linker_warnings option. By default fatal linker warnings are enabled. BUG= Committed: https://crrev.com/c804b74f6c3af31b74fbf652c38e8d5c61655b91 Cr-Commit-Position: refs/heads/master@{#403252} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c804b74f6c3af31b74fbf652c38e8d5c61655b91 Cr-Commit-Position: refs/heads/master@{#403252}
Message was sent while issue was closed.
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2119593002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/2119593002/diff/1/build/config/compiler/BUILD... build/config/compiler/BUILD.gn:88: fatal_linker_warnings = true We don't support building Chromium on 32-bit linux hosts any more (you need a 64-bit system to build, even if you're going to run on 32-bit targets). So, linking to that bug isn't a good example. Are there other bugs that we can link against? Maybe you can point to a current need for this flag?
Message was sent while issue was closed.
On 2016/06/30 20:00:41, Dirk Pranke wrote: > https://codereview.chromium.org/2119593002/diff/1/build/config/compiler/BUILD.gn > File build/config/compiler/BUILD.gn (right): > > https://codereview.chromium.org/2119593002/diff/1/build/config/compiler/BUILD... > build/config/compiler/BUILD.gn:88: fatal_linker_warnings = true > We don't support building Chromium on 32-bit linux hosts any more (you need a > 64-bit system to build, even if you're going to run on 32-bit targets). > > So, linking to that bug isn't a good example. Are there other bugs that we can > link against? Maybe you can point to a current need for this flag? thanks for the review. I'm building on 64bit for ARM64, using OpenEmbedded generated rootfs with binutils 2.25, gold linker. The issue is that I'm getting linker warnings " warning: hidden symbol" when linking to sqlite3. My goal is to improve the upstream support for ARM64 Linux builds on non-x11 setups with Mali GPUs.
Message was sent while issue was closed.
On 2016/07/01 06:04:01, zoli wrote: > On 2016/06/30 20:00:41, Dirk Pranke wrote: > > > https://codereview.chromium.org/2119593002/diff/1/build/config/compiler/BUILD.gn > > File build/config/compiler/BUILD.gn (right): > > > > > https://codereview.chromium.org/2119593002/diff/1/build/config/compiler/BUILD... > > build/config/compiler/BUILD.gn:88: fatal_linker_warnings = true > > We don't support building Chromium on 32-bit linux hosts any more (you need a > > 64-bit system to build, even if you're going to run on 32-bit targets). > > > > So, linking to that bug isn't a good example. Are there other bugs that we can > > link against? Maybe you can point to a current need for this flag? > > thanks for the review. > > I'm building on 64bit for ARM64, using OpenEmbedded generated rootfs with > binutils 2.25, gold linker. > The issue is that I'm getting linker warnings " warning: hidden symbol" when > linking to sqlite3. > > My goal is to improve the upstream support for ARM64 Linux builds on non-x11 > setups with Mali GPUs. Thanks for the reply. That sounds fine. Can you maybe post a follow-up CL that adds a comment that some chromium ports still use "older" binutils and may produce warnings that should be ignored, and get rid of the bug link instead? |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
