[Chromecast] Set Cast Ozone display size correctly first time

[Chromecast] Set Cast Ozone display size correctly first time

Now that we have fixed physical display resolution, we can set
the initial display size correctly, and there is no need for the
resize logic.

BUG=internal b/29391986

Committed: https://crrev.com/8fe22a9cac7aa8809b98e92686018ea300964a82
Cr-Commit-Position: refs/heads/master@{#404465}

[halliwell, 2016-06-30 17:33:02]

Description was changed from

==========
[Chromecast] Set Cast Ozone display size correctly first time

Now that we have fixed physical display resolution, we can set
the initial display size correctly, and there is no need for the
resize logic.

BUG=internal b/29391986
==========

to

==========
[Chromecast] Set Cast Ozone display size correctly first time

Now that we have fixed physical display resolution, we can set
the initial display size correctly, and there is no need for the
resize logic.

BUG=internal b/29391986
==========

[halliwell, 2016-06-30 17:33:02]

halliwell@chromium.org changed reviewers:
+ alokp@chromium.org, smcgruer@google.com

[halliwell, 2016-07-06 13:32:03]

On 2016/06/30 17:33:08, halliwell wrote:

ping on this.

[alokp, 2016-07-06 16:58:45]

lgtm % nots

https://codereview.chromium.org/2119583002/diff/1/chromecast/base/chromecast_...
File chromecast/base/chromecast_switches.cc (right):

https://codereview.chromium.org/2119583002/diff/1/chromecast/base/chromecast_...
chromecast/base/chromecast_switches.cc:83: const char kInitialScreenWidth[] =
"cast-initial-screen-width";
should this be name kCastInitialScreenWidth?

https://codereview.chromium.org/2119583002/diff/1/chromecast/browser/cast_con...
File chromecast/browser/cast_content_browser_client.cc (right):

https://codereview.chromium.org/2119583002/diff/1/chromecast/browser/cast_con...
chromecast/browser/cast_content_browser_client.cc:109:
command_line->AppendSwitchASCII(switches::kInitialScreenWidth,
It might be desirable to also allow specifying it on command line, in which case
you should query it from the command line and use primary display size only if
not present.

https://codereview.chromium.org/2119583002/diff/1/ui/ozone/platform/cast/surf...
File ui/ozone/platform/cast/surface_factory_cast.cc (right):

https://codereview.chromium.org/2119583002/diff/1/ui/ozone/platform/cast/surf...
ui/ozone/platform/cast/surface_factory_cast.cc:52: return gfx::Size(1280, 720);
LOG(WARNING)?

https://codereview.chromium.org/2119583002/diff/1/ui/ozone/platform/cast/surf...
ui/ozone/platform/cast/surface_factory_cast.cc:231: DCHECK_EQ(widget >> 16,
display_size_.width());
Add a comment what this DCHECK attempts to verify.

[halliwell, 2016-07-07 20:07:14]

smcgruer: please try again to verify with new patchset; I fixed the behaviour of
ResizeDisplay based on our discussion on the bug.  Works on my hardware now.

https://codereview.chromium.org/2119583002/diff/1/chromecast/base/chromecast_...
File chromecast/base/chromecast_switches.cc (right):

https://codereview.chromium.org/2119583002/diff/1/chromecast/base/chromecast_...
chromecast/base/chromecast_switches.cc:83: const char kInitialScreenWidth[] =
"cast-initial-screen-width";
On 2016/07/06 16:58:44, alokp wrote:
> should this be name kCastInitialScreenWidth?

Done.

https://codereview.chromium.org/2119583002/diff/1/chromecast/browser/cast_con...
File chromecast/browser/cast_content_browser_client.cc (right):

https://codereview.chromium.org/2119583002/diff/1/chromecast/browser/cast_con...
chromecast/browser/cast_content_browser_client.cc:109:
command_line->AppendSwitchASCII(switches::kInitialScreenWidth,
On 2016/07/06 16:58:44, alokp wrote:
> It might be desirable to also allow specifying it on command line, in which
case
> you should query it from the command line and use primary display size only if
> not present.

Done.

https://codereview.chromium.org/2119583002/diff/1/ui/ozone/platform/cast/surf...
File ui/ozone/platform/cast/surface_factory_cast.cc (right):

https://codereview.chromium.org/2119583002/diff/1/ui/ozone/platform/cast/surf...
ui/ozone/platform/cast/surface_factory_cast.cc:52: return gfx::Size(1280, 720);
On 2016/07/06 16:58:44, alokp wrote:
> LOG(WARNING)?

Done.

https://codereview.chromium.org/2119583002/diff/1/ui/ozone/platform/cast/surf...
ui/ozone/platform/cast/surface_factory_cast.cc:231: DCHECK_EQ(widget >> 16,
display_size_.width());
On 2016/07/06 16:58:44, alokp wrote:
> Add a comment what this DCHECK attempts to verify.

Done.

[halliwell, 2016-07-08 18:25:48]

The CQ bit was checked by halliwell@chromium.org

[halliwell, 2016-07-08 18:25:48]

The patchset sent to the CQ was uploaded after l-g-t-m from alokp@chromium.org
Link to the patchset: https://codereview.chromium.org/2119583002/#ps20001
(title: "Nits + fix ResizeDisplay")

[commit-bot: I haz the power, 2016-07-08 18:26:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 19:39:43]

Description was changed from

==========
[Chromecast] Set Cast Ozone display size correctly first time

Now that we have fixed physical display resolution, we can set
the initial display size correctly, and there is no need for the
resize logic.

BUG=internal b/29391986
==========

to

==========
[Chromecast] Set Cast Ozone display size correctly first time

Now that we have fixed physical display resolution, we can set
the initial display size correctly, and there is no need for the
resize logic.

BUG=internal b/29391986
==========

[commit-bot: I haz the power, 2016-07-08 19:39:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-08 19:40:00]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 19:40:52]

Description was changed from

==========
[Chromecast] Set Cast Ozone display size correctly first time

Now that we have fixed physical display resolution, we can set
the initial display size correctly, and there is no need for the
resize logic.

BUG=internal b/29391986
==========

to

==========
[Chromecast] Set Cast Ozone display size correctly first time

Now that we have fixed physical display resolution, we can set
the initial display size correctly, and there is no need for the
resize logic.

BUG=internal b/29391986

Committed: https://crrev.com/8fe22a9cac7aa8809b98e92686018ea300964a82
Cr-Commit-Position: refs/heads/master@{#404465}
==========

[commit-bot: I haz the power, 2016-07-08 19:40:53]

Patchset 2 (id:??) landed as
https://crrev.com/8fe22a9cac7aa8809b98e92686018ea300964a82
Cr-Commit-Position: refs/heads/master@{#404465}