Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 2119583002: [Chromecast] Set Cast Ozone display size correctly first time (Closed)

Created:
4 years, 5 months ago by halliwell
Modified:
4 years, 5 months ago
Reviewers:
smcgruer2, alokp
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, ozone-reviews_chromium.org, halliwell+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Set Cast Ozone display size correctly first time Now that we have fixed physical display resolution, we can set the initial display size correctly, and there is no need for the resize logic. BUG=internal b/29391986 Committed: https://crrev.com/8fe22a9cac7aa8809b98e92686018ea300964a82 Cr-Commit-Position: refs/heads/master@{#404465}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Nits + fix ResizeDisplay #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -22 lines) Patch
M chromecast/base/chromecast_switches.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chromecast/base/chromecast_switches.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 1 3 chunks +17 lines, -0 lines 0 comments Download
M ui/ozone/platform/cast/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/cast/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/cast/surface_factory_cast.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/cast/surface_factory_cast.cc View 1 6 chunks +23 lines, -21 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
halliwell
4 years, 5 months ago (2016-06-30 17:33:08 UTC) #3
halliwell
On 2016/06/30 17:33:08, halliwell wrote: ping on this.
4 years, 5 months ago (2016-07-06 13:32:03 UTC) #4
alokp
lgtm % nots https://codereview.chromium.org/2119583002/diff/1/chromecast/base/chromecast_switches.cc File chromecast/base/chromecast_switches.cc (right): https://codereview.chromium.org/2119583002/diff/1/chromecast/base/chromecast_switches.cc#newcode83 chromecast/base/chromecast_switches.cc:83: const char kInitialScreenWidth[] = "cast-initial-screen-width"; should ...
4 years, 5 months ago (2016-07-06 16:58:45 UTC) #5
halliwell
smcgruer: please try again to verify with new patchset; I fixed the behaviour of ResizeDisplay ...
4 years, 5 months ago (2016-07-07 20:07:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119583002/20001
4 years, 5 months ago (2016-07-08 18:26:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 19:39:44 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 19:40:00 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 19:40:53 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8fe22a9cac7aa8809b98e92686018ea300964a82
Cr-Commit-Position: refs/heads/master@{#404465}

Powered by Google App Engine
This is Rietveld 408576698