Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2119553002: [Mac] In base::mac::CxxPersonalityRoutine, delegate back to __gxx_personality_v0. (Closed)

Created:
4 years, 5 months ago by Robert Sesek
Modified:
4 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] In base::mac::CxxPersonalityRoutine, delegate back to __gxx_personality_v0. This fixes a hypothetical issue where returning _URC_END_OF_STACK in phase two of exception processing could confuse libunwind. If this personality routine is called in phase two, it will now delegate back to the normal C++ personality routine. See https://crbug.com/576941#c62 for details. BUG=576941 R=mark@chromium.org Committed: https://crrev.com/dd20bfda89d5d2a62175a690fc71009e36adb39d Cr-Commit-Position: refs/heads/master@{#403235}

Patch Set 1 #

Patch Set 2 : #if defines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
M base/mac/call_with_eh_frame.cc View 1 1 chunk +31 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Robert Sesek
4 years, 5 months ago (2016-06-30 18:20:16 UTC) #2
Mark Mentovai
LGTM
4 years, 5 months ago (2016-06-30 18:25:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119553002/40001
4 years, 5 months ago (2016-06-30 18:40:18 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-06-30 19:04:29 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 19:06:00 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dd20bfda89d5d2a62175a690fc71009e36adb39d
Cr-Commit-Position: refs/heads/master@{#403235}

Powered by Google App Engine
This is Rietveld 408576698