OLD | NEW |
1 # How to contribute | 1 # How to contribute |
2 | 2 |
3 ### Sign our Contributor License Agreement (CLA) | 3 ### Sign our Contributor License Agreement (CLA) |
4 | 4 |
5 Even for small changes, we ask that you please sign the CLA electronically | 5 Even for small changes, we ask that you please sign the CLA electronically |
6 [here](https://developers.google.com/open-source/cla/individual). | 6 [here](https://developers.google.com/open-source/cla/individual). |
7 The CLA is necessary because you own the copyright to your changes, even | 7 The CLA is necessary because you own the copyright to your changes, even |
8 after your contribution becomes part of our codebase, so we need your permission | 8 after your contribution becomes part of our codebase, so we need your permission |
9 to use and distribute your code. You can find more details | 9 to use and distribute your code. You can find more details |
10 [here](https://code.google.com/p/dart/wiki/Contributing). You'll only need to | 10 [here](https://code.google.com/p/dart/wiki/Contributing). You'll only need to |
11 do this once. | 11 do this once. |
12 | 12 |
13 ### Contribution Guidelines | 13 ### Contribution Guidelines |
14 | 14 |
15 We welcome your pull requests, issue reports and enhacement requests. To make | 15 We welcome your pull requests, issue reports and enhancement requests. To make |
16 the process as smooth as possible, we request the following: | 16 the process as smooth as possible, we request the following: |
17 | 17 |
18 * Sign the [CLA](https://cla.developers.google.com/about/google-individual) | 18 * Sign the [CLA](https://cla.developers.google.com/about/google-individual) |
19 (see above) before sending your pull request. It's quick, we promise! | 19 (see above) before sending your pull request. It's quick, we promise! |
20 * Have test cases for your changes and ensure that the existing ones pass in | 20 * Have test cases for your changes and ensure that the existing ones pass in |
21 checked mode. | 21 checked mode. |
22 * Run your changes through `dartformat`. Follow the installation instructions | 22 * Run your changes through `dartfmt`. Follow the installation instructions |
23 in the [dart_style](https://github.com/dart-lang/dart_style) README for | 23 in the [dart_style](https://github.com/dart-lang/dart_style) README for |
24 more info. | 24 more info. |
25 * Squash your commits into a single commit with a good description. You can | 25 * Squash your commits into a single commit with a good description. You can |
26 use `git rebase -i` for this. For more details on rebasing, check out | 26 use `git rebase -i` for this. For more details on rebasing, check out |
27 Atlassian's | 27 Atlassian's |
28 [tutorial](https://www.atlassian.com/git/tutorials/rewriting-history). | 28 [tutorial](https://www.atlassian.com/git/tutorials/rewriting-history). |
29 * During code review, go ahead and pile up commits addressing review | 29 * During code review, go ahead and pile up commits addressing review |
30 comments. Once you get an LGTM (looks good to me) on the review, we'll ask | 30 comments. Once you get an LGTM (looks good to me) on the review, we'll ask |
31 you to squash your commits one last time, then we'll be good to merge! | 31 you to squash your commits one last time, then we'll be good to merge! |
OLD | NEW |