Reland "Allow multiple devices on bisects hosts "

scripts/slave/recipe_modules/auto_bisect/local_bisect.py

Index: scripts/slave/recipe_modules/auto_bisect/local_bisect.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/local_bisect.py b/scripts/slave/recipe_modules/auto_bisect/local_bisect.py
index c5fb2cc8d93d65c0d111a9420be62228f68ddc0e..4271e26fc0fb771f67571fb168df4bc28085a83b 100644
--- a/scripts/slave/recipe_modules/auto_bisect/local_bisect.py
+++ b/scripts/slave/recipe_modules/auto_bisect/local_bisect.py
@@ -7,27 +7,61 @@ import collections
 import json
 
 
-def perform_bisect(api, **flags):  # pragma: no cover
-  bisect_config = api.m.properties.get('bisect_config')
-  assert isinstance(bisect_config, collections.Mapping)
-  bisector = api.create_bisector(bisect_config, **flags)
-  with api.m.step.nest('Gathering reference values'):
-    _gather_reference_range(api, bisector)
-  if (not bisector.failed and bisector.check_improvement_direction() and
-      bisector.check_initial_confidence()):
-    if bisector.check_reach_adjacent_revision(bisector.good_rev):
-      # Only show this step if bisect has reached adjacent revisions.
-      with api.m.step.nest(str('Check bisect finished on revision ' +
-                               bisector.good_rev.revision_string())):
-        if bisector.check_bisect_finished(bisector.good_rev):
-          bisector.bisect_over = True
-    if not bisector.bisect_over:
-      _bisect_main_loop(bisector)
-  else:
-    bisector.bisect_over = True
-  bisector.print_result_debug_info()
-  bisector.post_result(halt_on_failure=True)
+def perform_bisect(api, **flags):
+  # pick an available device if targe platform is android
+  if api.m.chromium.c.TARGET_PLATFORM == 'android':
+    connected_devices = _get_connected_devices(api)
+    if not _pick_available_device(api, connected_devices):
+      raise api.m.step.StepFailure('No Android test devices are available')
+  try:
+      bisect_config = api.m.properties.get('bisect_config')
+      assert isinstance(bisect_config, collections.Mapping)
+      bisector = api.create_bisector(bisect_config, **flags)
+      with api.m.step.nest('Gathering reference values'):
+        _gather_reference_range(api, bisector)
+      if (not bisector.failed and bisector.check_improvement_direction() and
+          bisector.check_initial_confidence()):
+        if bisector.check_reach_adjacent_revision(
+            bisector.good_rev): # pragma: no cover
+          # Only show this step if bisect has reached adjacent revisions.
+          with api.m.step.nest(str('Check bisect finished on revision ' +
+                                   bisector.good_rev.revision_string())):
+            if bisector.check_bisect_finished(bisector.good_rev):
+              bisector.bisect_over = True
+        if not bisector.bisect_over:
+          _bisect_main_loop(bisector)
+      else:
+        bisector.bisect_over = True
+      bisector.print_result_debug_info()
+      bisector.post_result(halt_on_failure=True)
+  except api.m.step.StepFailure:
+      # Redo the bisect job if target platform is android and bisect failed
+      # because the test device disconnected
+      if api.m.chromium.c.TARGET_PLATFORM == 'android':
+        connected_devices = _get_connected_devices(api)
+        if api.m.bisect_tester.device_to_test not in connected_devices:
+          perform_bisect(api, **flags)
+        else:
+          raise
+      else: # pragma: no cover
+        raise
+
+def _get_connected_devices(api):
+  api.m.chromium_android.multiple_device_test = True
+  api.m.chromium_android.device_status_check()
+  api.m.chromium_android.multiple_device_test = False
+  return api.m.chromium_android.devices
 
+def _pick_available_device(api, connected_devices):
+  tested_devices = api.m.bisect_tester.devices_tested
+  available_devices = [device for device in connected_devices
+                              if device not in tested_devices]
+  if available_devices:
+    picked_device = available_devices[0]
+    api.m.bisect_tester.device_to_test = picked_device
+    api.m.bisect_tester.devices_tested.append(picked_device)
+    return picked_device
+  return None
 
 def _gather_reference_range(api, bisector):  # pragma: no cover
   bisector.good_rev.start_job()