Issue 2119473002: use mapRectScaleTranslate for common case in clipRect

Issue 2119473002: use mapRectScaleTranslate for common case in clipRect (Closed)

Created:
4 years, 5 months ago by reed1

Modified:
4 years, 5 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	src/core/SkCanvas.cpp	View		4 chunks	+9 lines, -9 lines	0 comments	Download

Total messages: 13 (6 generated)

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119473002/1

4 years, 5 months ago (2016-06-30 14:35:17 UTC) #3

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 5 months ago (2016-06-30 15:05:03 UTC) #7

mtklein

This lgtm, but would lbtm with a mapRect version that returns the result by value.

4 years, 5 months ago (2016-06-30 15:14:01 UTC) #8

reed1

On 2016/06/30 15:14:01, mtklein wrote: > This lgtm, but would lbtm with a mapRect version ...

4 years, 5 months ago (2016-06-30 15:14:31 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119473002/1

4 years, 5 months ago (2016-06-30 15:14:43 UTC) #11

commit-bot: I haz the power

4 years, 5 months ago (2016-06-30 15:15:39 UTC) #13

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/744671639dae1d5589181856d54cf0dfdb59272d